From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED89CC433DB for ; Tue, 26 Jan 2021 22:02:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 66FA220656 for ; Tue, 26 Jan 2021 22:02:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66FA220656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B8FE18D0116; Tue, 26 Jan 2021 17:02:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B1A4C8D00F8; Tue, 26 Jan 2021 17:02:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A090D8D0116; Tue, 26 Jan 2021 17:02:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 867A58D00F8 for ; Tue, 26 Jan 2021 17:02:58 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 50B98824999B for ; Tue, 26 Jan 2021 22:02:58 +0000 (UTC) X-FDA: 77749302036.18.scale99_5b00edf27591 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 23FEC100ED9DC for ; Tue, 26 Jan 2021 22:02:58 +0000 (UTC) X-HE-Tag: scale99_5b00edf27591 X-Filterd-Recvd-Size: 2716 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Jan 2021 22:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nt9yKUXomDG8uLOcOikYEqr2InI/DibgiRpwpXD2IgY=; b=SkEWbAkylDaIJYoorL3DBzwrFe DnzLBZxI6n9mOZNh8sxsvc8iCIg/uMqXEVeyh0j+5uCsYWv9l56RFBJ4512MxVkk3h8xwhOaxmVSm C3McFHe3ENKal3y/2GpbXOAUPhzqEtCJkw9QJ6HLWYjnlndMVSHwTZUkoCwQQwzgS5HZPyTkXbbAe ZeMJKFAKCO36xCtJ1KSvdCGpWfnt8hk99EU+xTEhXqt5JPzVjBBAKyi9+yOQyU1RIS+B55Bxd3kph Snqwcx3BokFqqa269TeLZOQH6Y4WaWgiKAuPLWjYsxUrnUGmqllJSUMSfgrVxEhqxhqdAQzjh1Ocw Q20fedmw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l4WOd-006JeE-V6; Tue, 26 Jan 2021 22:01:36 +0000 Date: Tue, 26 Jan 2021 22:01:11 +0000 From: Matthew Wilcox To: Yu Zhao Cc: Andrew Morton , Hugh Dickins , Alex Shi , Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/10] mm: don't pass "enum lru_list" to lru list addition functions Message-ID: <20210126220111.GO308988@casper.infradead.org> References: <20210122220600.906146-1-yuzhao@google.com> <20210122220600.906146-4-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210122220600.906146-4-yuzhao@google.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 22, 2021 at 03:05:53PM -0700, Yu Zhao wrote: > +++ b/mm/swap.c > @@ -231,7 +231,7 @@ static void pagevec_move_tail_fn(struct page *page, struct lruvec *lruvec) > if (!PageUnevictable(page)) { > del_page_from_lru_list(page, lruvec, page_lru(page)); > ClearPageActive(page); > - add_page_to_lru_list_tail(page, lruvec, page_lru(page)); > + add_page_to_lru_list_tail(page, lruvec); > __count_vm_events(PGROTATED, thp_nr_pages(page)); > } Is it profitable to do ... - del_page_from_lru_list(page, lruvec, page_lru(page)); + enum lru_list lru = page_lru(page); + del_page_from_lru_list(page, lruvec, lru); ClearPageActive(page); - add_page_to_lru_list_tail(page, lruvec, page_lru(page)); + lru &= ~LRU_ACTIVE; + add_page_to_lru_list_tail(page, lruvec, lru);