From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA28C43381 for ; Tue, 26 Jan 2021 17:40:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2AAF922B2C for ; Tue, 26 Jan 2021 17:40:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AAF922B2C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BB9978D00FA; Tue, 26 Jan 2021 12:40:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B69AF8D00F8; Tue, 26 Jan 2021 12:40:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A58E08D00FA; Tue, 26 Jan 2021 12:40:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 8AF048D00F8 for ; Tue, 26 Jan 2021 12:40:36 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 482B98249980 for ; Tue, 26 Jan 2021 17:40:36 +0000 (UTC) X-FDA: 77748640872.24.smoke52_0c172c627590 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 2D8EA1A4A5 for ; Tue, 26 Jan 2021 17:40:36 +0000 (UTC) X-HE-Tag: smoke52_0c172c627590 X-Filterd-Recvd-Size: 2668 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Jan 2021 17:40:35 +0000 (UTC) Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 889A02228A; Tue, 26 Jan 2021 17:40:33 +0000 (UTC) Date: Tue, 26 Jan 2021 12:40:32 -0500 From: Steven Rostedt To: Timur Tabi Cc: Vlastimil Babka , Sergey Senozhatsky , Matthew Wilcox , Andrew Morton , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, Petr Mladek , roman.fietze@magna.com, keescook@chromium.org, John Ogness , linux-mm@kvack.org, Akinobu Mita Subject: Re: [PATCH 0/2] introduce DUMP_PREFIX_UNHASHED for hex dumps Message-ID: <20210126124032.0915f408@gandalf.local.home> In-Reply-To: <20210126123912.23a5c3a1@gandalf.local.home> References: <20210116220950.47078-1-timur@kernel.org> <20210118182635.GD2260413@casper.infradead.org> <20210119014725.GH2260413@casper.infradead.org> <09c70d6b-c989-ca23-7ee8-b404bb0490f0@suse.cz> <083dd940-60c1-4cc8-fc89-8815b253d5c5@suse.cz> <20210126123912.23a5c3a1@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 26 Jan 2021 12:39:12 -0500 Steven Rostedt wrote: > On Tue, 26 Jan 2021 11:30:02 -0600 > Timur Tabi wrote: > > > On 1/26/21 11:14 AM, Vlastimil Babka wrote: > > > If it was a boot option, I would personally be for leaving hashing enabled by > > > default, with opt-in boot option to disable it. > > > > A boot option would solve all my problems. I wouldn't need to recompile > > the kernel, and it would apply to all variations of printk. > > Should it be called "make-printk-insecure" > > ? And even if we make this a boot time option, perhaps we should still include that nasty dmesg notice, which will let people know that the kernel has unhashed values. -- Steve