From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E206DC433E6 for ; Tue, 26 Jan 2021 06:39:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8F552206F7 for ; Tue, 26 Jan 2021 06:39:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F552206F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2A29A8D0098; Tue, 26 Jan 2021 01:39:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 251028D0076; Tue, 26 Jan 2021 01:39:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18F068D0098; Tue, 26 Jan 2021 01:39:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 044D38D0076 for ; Tue, 26 Jan 2021 01:39:12 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C91DB181AF5C3 for ; Tue, 26 Jan 2021 06:39:11 +0000 (UTC) X-FDA: 77746974102.21.love62_4c1013d2758c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id A9838180442C3 for ; Tue, 26 Jan 2021 06:39:11 +0000 (UTC) X-HE-Tag: love62_4c1013d2758c X-Filterd-Recvd-Size: 1481 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Jan 2021 06:39:11 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id D544F68B02; Tue, 26 Jan 2021 07:39:08 +0100 (CET) Date: Tue, 26 Jan 2021 07:39:08 +0100 From: Christoph Hellwig To: Nicholas Piggin Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 5/5] mm/vmalloc: improve allocation failure error messages Message-ID: <20210126063908.GE26674@lst.de> References: <20210126045404.2492588-1-npiggin@gmail.com> <20210126045404.2492588-6-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126045404.2492588-6-npiggin@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 26, 2021 at 02:54:04PM +1000, Nicholas Piggin wrote: > There are several reasons why a vmalloc can fail, virtual space > exhausted, page array allocation failure, page allocation failure, > and kernel page table allocation failure. > > Add distinct warning messages for the main causes of failure, with > some added information like page order or allocation size where > applicable. > > Signed-off-by: Nicholas Piggin Looks good, Reviewed-by: Christoph Hellwig