From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B92C433DB for ; Tue, 26 Jan 2021 06:38:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D395B22B3F for ; Tue, 26 Jan 2021 06:38:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D395B22B3F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3DA538D0097; Tue, 26 Jan 2021 01:38:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B0DB8D0076; Tue, 26 Jan 2021 01:38:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EE0F8D0097; Tue, 26 Jan 2021 01:38:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id 145F58D0076 for ; Tue, 26 Jan 2021 01:38:54 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D89C2180ACEE4 for ; Tue, 26 Jan 2021 06:38:53 +0000 (UTC) X-FDA: 77746973346.21.light30_33076562758c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id BC570180442C3 for ; Tue, 26 Jan 2021 06:38:53 +0000 (UTC) X-HE-Tag: light30_33076562758c X-Filterd-Recvd-Size: 1241 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Jan 2021 06:38:53 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 777A368C4E; Tue, 26 Jan 2021 07:38:51 +0100 (CET) Date: Tue, 26 Jan 2021 07:38:51 +0100 From: Christoph Hellwig To: Nicholas Piggin Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 4/5] mm/vmalloc: remove unmap_kernel_range Message-ID: <20210126063851.GD26674@lst.de> References: <20210126045404.2492588-1-npiggin@gmail.com> <20210126045404.2492588-5-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126045404.2492588-5-npiggin@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 26, 2021 at 02:54:03PM +1000, Nicholas Piggin wrote: > This is a shim around vunmap_range, get rid of it. > > Move the main API comment from the _noflush variant to the normal > variant, and make _noflush internal to mm/. Looks good, Reviewed-by: Christoph Hellwig