From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE48C433DB for ; Mon, 25 Jan 2021 18:31:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9F06922D04 for ; Mon, 25 Jan 2021 18:31:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F06922D04 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 18E296B007B; Mon, 25 Jan 2021 13:31:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 118656B007E; Mon, 25 Jan 2021 13:31:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 008236B0080; Mon, 25 Jan 2021 13:31:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id DAF456B007B for ; Mon, 25 Jan 2021 13:31:15 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A42BA180AD838 for ; Mon, 25 Jan 2021 18:31:15 +0000 (UTC) X-FDA: 77745139710.15.shelf01_0308c5127587 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 0420C1814B0E5 for ; Mon, 25 Jan 2021 18:31:08 +0000 (UTC) X-HE-Tag: shelf01_0308c5127587 X-Filterd-Recvd-Size: 2871 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 18:31:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1611599467; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uqGPhwP3Lp8NPepOOe5fR+cd2R65FBDmRR/EArzQzA8=; b=ua3+I4lEcHFW3ioskhY8N98ODDCWluL0+MzmmP+epwSO6nGcXihX+PJVNhmyrVHO2Ns7XR PsfPk6klzDOztgREfEaDFQ9LJdnxIZSwzg74N8LwVaYcGOV1KZfTj7mUijLPk2YPRgD0Mi qyLaWMTT9MktCvWnX0Ksi8a4xVAF9Dk= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1EB7DAE1F; Mon, 25 Jan 2021 18:31:07 +0000 (UTC) Date: Mon, 25 Jan 2021 19:31:05 +0100 From: Michal Hocko To: Waiman Long Cc: Matthew Wilcox , Andrew Morton , Johannes Weiner , Alex Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/filemap: Adding missing mem_cgroup_uncharge() to __add_to_page_cache_locked() Message-ID: <20210125183105.GW827@dhcp22.suse.cz> References: <20210125042441.20030-1-longman@redhat.com> <20210125092815.GB827@dhcp22.suse.cz> <20210125160328.GP827@dhcp22.suse.cz> <20210125162506.GF308988@casper.infradead.org> <20210125164118.GS827@dhcp22.suse.cz> <20210125181436.GV827@dhcp22.suse.cz> <53eb7692-e559-a914-e103-adfe951d7a7c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <53eb7692-e559-a914-e103-adfe951d7a7c@redhat.com> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 25-01-21 13:23:58, Waiman Long wrote: > On 1/25/21 1:14 PM, Michal Hocko wrote: [...] > > With the proposed simplification by Willy > > Acked-by: Michal Hocko >=20 > Thank for the ack. However, I am a bit confused about what you mean by > simplification. There is another linux-next patch that changes the cond= ition > for mem_cgroup_charge() to This is obviously a fix and I believe should go in the next rc while secretmem is a new feature which should wait at least to the next merge window. > -=A0=A0=A0=A0=A0=A0 if (!huge) { > +=A0=A0=A0=A0=A0=A0 if (!huge && !page_is_secretmem(page)) { > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 error =3D mem_cgroup_char= ge(page, current->mm, gfp); >=20 > That is the main reason why I introduced the boolean variable as I don'= t > want to call the external page_is_secretmem() function twice. >=20 > Cheers, > Longman >=20 --=20 Michal Hocko SUSE Labs