From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91AB9C433E0 for ; Mon, 25 Jan 2021 15:33:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2EDC722A84 for ; Mon, 25 Jan 2021 15:33:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EDC722A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 901558D0007; Mon, 25 Jan 2021 10:33:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B30F8D0001; Mon, 25 Jan 2021 10:33:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F00E8D0007; Mon, 25 Jan 2021 10:33:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 6935D8D0001 for ; Mon, 25 Jan 2021 10:33:15 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 28705181AC9CC for ; Mon, 25 Jan 2021 15:33:15 +0000 (UTC) X-FDA: 77744691150.18.cow23_4211fca27586 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id F13BD100ED9C4 for ; Mon, 25 Jan 2021 15:33:14 +0000 (UTC) X-HE-Tag: cow23_4211fca27586 X-Filterd-Recvd-Size: 2709 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 15:33:14 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3A2F023B87; Mon, 25 Jan 2021 15:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611588793; bh=UUqFz1GCDzeajvsIz4oIG+JUrq9IF12fIPbYDXS1rmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G3FP1W05HV8KVZ1L7JANRqbSkd19MZY3xu2YlCzZS2NeBhwUGgk2VO8fqn4bbElLA pNLPkq92eVYG7zDfnLEZiLufvN/5/q2IDC1tCClVDZTNkWDLBlP04Fa7+lPSF+EW1l VHbkVM0KDODfZFpI5cLuW4vtmwxUhuxrHg/2s43xsMRPXiwDr7+T3JAmrRiTsJoPlm k98K7L7G3Z67fLIorg9UpGTtn/3B09ebV/JGr+wrkXpnWywnh21QTSlJqWq0dVp63o /eu2i8AESrhKFqn3c3cpxVAZexvMh7BBXsAwy6+ailA2RdyqJWsVd18Dg8Go7TGMZT OS9j2DjtjSZ0g== Date: Mon, 25 Jan 2021 17:33:03 +0200 From: Mike Rapoport To: Borislav Petkov Cc: Andrew Morton , Andrea Arcangeli , Baoquan He , David Hildenbrand , "H. Peter Anvin" , Ingo Molnar , Mel Gorman , Michal Hocko , Mike Rapoport , Qian Cai , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH 1/2] x86/setup: consolidate early memory reservations Message-ID: <20210125153303.GI6332@kernel.org> References: <20210115083255.12744-1-rppt@kernel.org> <20210115083255.12744-2-rppt@kernel.org> <20210125145911.GF23070@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210125145911.GF23070@zn.tnic> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 25, 2021 at 03:59:11PM +0100, Borislav Petkov wrote: > On Fri, Jan 15, 2021 at 10:32:54AM +0200, Mike Rapoport wrote: > > + trim_low_memory_range(); > > Btw, you can get rid of that one too: > > /* > * Here we put platform-specific memory range workarounds, i.e. > * memory known to be corrupt or otherwise in need to be reserved on > * specific platforms. > * > * If this gets used more widely it could use a real dispatch mechanism. > */ > static void __init trim_platform_memory_ranges(void) > { > trim_snb_memory(); > } > > yeah, yeah, we can do a real dispatch mechanism but we didn't need one > since 2012 so I guess we can get rid of trim_platform_memory_ranges() > and call trim_snb_memory() directly and simplify it even more. Ok. > Thx. > -- Sincerely yours, Mike.