From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8262DC433DB for ; Mon, 25 Jan 2021 23:11:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F081E229EF for ; Mon, 25 Jan 2021 23:11:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F081E229EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B8F28D005A; Mon, 25 Jan 2021 18:11:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36AF78D0059; Mon, 25 Jan 2021 18:11:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 280228D005A; Mon, 25 Jan 2021 18:11:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id 124928D0059 for ; Mon, 25 Jan 2021 18:11:15 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C92DC1EE6 for ; Mon, 25 Jan 2021 23:11:14 +0000 (UTC) X-FDA: 77745845268.01.map45_2a1154727589 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 831351004F638 for ; Mon, 25 Jan 2021 23:11:14 +0000 (UTC) X-HE-Tag: map45_2a1154727589 X-Filterd-Recvd-Size: 2006 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 23:11:13 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 86293229C4; Mon, 25 Jan 2021 23:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1611616272; bh=X7bRUoPwXu8J9VKI55RqWL4PrEa6+q0BmTV/swTO4uw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OQCCTo8yw5FY7cE+Nj81t3IOOaDnURS8q3G12ie3SioxqH3u1uKMm1MfhkCZwUHsk dN/WsUVVUYWk5SvzWK+eTlsAFQZ0XgVVY3kGkSdEx6PlfEhlm3lXWD511DfaP+GjJn bj/ptaefY0DhcJyOzxJnd461N2LL1p+cx5bJIy0o= Date: Mon, 25 Jan 2021 15:11:11 -0800 From: Andrew Morton To: Waiman Long Cc: Miaohe Lin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Alex Shi Subject: Re: [PATCH] mm/filemap: Adding missing mem_cgroup_uncharge() to __add_to_page_cache_locked() Message-Id: <20210125151111.0da207db337a575e5346bd08@linux-foundation.org> In-Reply-To: <4367cc87-1ebf-6df2-d2d4-939c548ca790@redhat.com> References: <20210125042441.20030-1-longman@redhat.com> <3b3f2b56-e66a-db5e-8d8e-95f3812c6838@huawei.com> <4367cc87-1ebf-6df2-d2d4-939c548ca790@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 25 Jan 2021 09:12:56 -0500 Waiman Long wrote: > Yes, this patch should go to stable. I think the stable tree maintainers > will automatically pick up patches with the "Fixes" tag. That is why I > don't explicitly put a "cc:stable" line in the patch. No. Both the Fixes: and the cc:stable are needed for the backport. Because sometimes we fix things but don't consider the fix important enough to risk the backport.