From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3BD3C433E0 for ; Mon, 25 Jan 2021 13:07:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22A4A22D04 for ; Mon, 25 Jan 2021 13:07:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22A4A22D04 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2AEEA8D0003; Mon, 25 Jan 2021 08:07:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 260488D0001; Mon, 25 Jan 2021 08:07:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 175198D0003; Mon, 25 Jan 2021 08:07:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 022B58D0001 for ; Mon, 25 Jan 2021 08:07:04 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AECD0181AEF3F for ; Mon, 25 Jan 2021 13:07:04 +0000 (UTC) X-FDA: 77744322768.28.pot52_310e8c527586 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 7EE096C11 for ; Mon, 25 Jan 2021 13:07:04 +0000 (UTC) X-HE-Tag: pot52_310e8c527586 X-Filterd-Recvd-Size: 3052 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 13:07:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1611580022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IhcDfMh/jgC3sT4h+BE3+sZhvOB29e/Mf8pMb+zJIT0=; b=pqbf9RDe5VxSZd9L0YIIOoOlPu/IynyL+x6JpR3MRCabAN3cLPy3Zjwo/H1rJHa9kRkA7A uA7NaxsuOURWeuXjI5lKxMjaCgFUU4QZiVqGL/HjT7bc4EWUeVa7RiuinVL2lnDRKNVHCr 5xu4S2KojVAYad9KZN/+J6Lg/NCBAu8= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9BAE1AAC6; Mon, 25 Jan 2021 13:07:02 +0000 (UTC) Date: Mon, 25 Jan 2021 14:07:01 +0100 From: Michal Hocko To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , hyesoo.yu@samsung.com, david@redhat.com, surenb@google.com, pullip.cho@samsung.com, joaodias@google.com, hridya@google.com, john.stultz@linaro.org, sumit.semwal@linaro.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, hch@infradead.org, robh+dt@kernel.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v4 1/4] mm: cma: introduce gfp flag in cma_alloc instead of no_warn Message-ID: <20210125130701.GF827@dhcp22.suse.cz> References: <20210121175502.274391-1-minchan@kernel.org> <20210121175502.274391-2-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121175502.274391-2-minchan@kernel.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 21-01-21 09:54:59, Minchan Kim wrote: > The upcoming patch will introduce __GFP_NORETRY semantic > in alloc_contig_range which is a failfast mode of the API. > Instead of adding a additional parameter for gfp, replace > no_warn with gfp flag. > > To keep old behaviors, it follows the rule below. > > no_warn gfp_flags > > false GFP_KERNEL > true GFP_KERNEL|__GFP_NOWARN > gfp & __GFP_NOWARN GFP_KERNEL | (gfp & __GFP_NOWARN) > > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Minchan Kim [...] > diff --git a/mm/cma.c b/mm/cma.c > index 0ba69cd16aeb..d50627686fec 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -419,13 +419,13 @@ static inline void cma_debug_show_areas(struct cma *cma) { } > * @cma: Contiguous memory region for which the allocation is performed. > * @count: Requested number of pages. > * @align: Requested alignment of pages (in PAGE_SIZE order). > - * @no_warn: Avoid printing message about failed allocation > + * @gfp_mask: GFP mask to use during the cma allocation. Call out supported gfp flags explicitly. Have a look at kvmalloc_node for a guidance. -- Michal Hocko SUSE Labs