From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF31C433E0 for ; Sun, 24 Jan 2021 11:41:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AB9E722C9F for ; Sun, 24 Jan 2021 11:41:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB9E722C9F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 07DC06B0007; Sun, 24 Jan 2021 06:41:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02ED96B000A; Sun, 24 Jan 2021 06:41:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E86346B000C; Sun, 24 Jan 2021 06:41:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id D31606B0007 for ; Sun, 24 Jan 2021 06:41:23 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9D5633621 for ; Sun, 24 Jan 2021 11:41:23 +0000 (UTC) X-FDA: 77740478046.11.time26_351334b2757c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 8009B180F8B81 for ; Sun, 24 Jan 2021 11:41:23 +0000 (UTC) X-HE-Tag: time26_351334b2757c X-Filterd-Recvd-Size: 3096 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Sun, 24 Jan 2021 11:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M3FSAWCV2zmyTdtnVy67d93WEezl2jaS3Y+9V7bxgfg=; b=TIp1qmX+Wc+PSElTTUMYQCiVsq byjIKNxpCDGZTlBLtYSCfzzBQ/svyQIdDu8hmDtW57KcoQgW4aMH8avBI7mkjFI66OoQe4tP6TXY+ VntHOHWgpyQaw54rxeyxKYBsI4YiaNhltMoEV3QvqI+fYWJOLY+uZsHc97xgSqpC+RFRUzNVB+Dal 4ucRF9Z02bGcU7dN2MBNgHSDeanSSmIEuyLn1FMgjM5GYDzQL6dd0R9c+ur3uNZHpHYf3faGylVML qd31reJoqDmyOsc47wypl/AVuY1rQoeVIPwisZOoFAY3IKgbNNtBUVwdUf5XD4bi9xxwtQn9Vh4zg /VGZlMAg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l3dkW-002v8C-GD; Sun, 24 Jan 2021 11:40:29 +0000 Date: Sun, 24 Jan 2021 11:40:08 +0000 From: Christoph Hellwig To: Nicholas Piggin Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Zefan Li , Jonathan Cameron , Christoph Hellwig , Christophe Leroy , Rick Edgecombe , Ding Tianhong , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v10 05/12] mm: HUGE_VMAP arch support cleanup Message-ID: <20210124114008.GE694255@infradead.org> References: <20210124082230.2118861-1-npiggin@gmail.com> <20210124082230.2118861-6-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210124082230.2118861-6-npiggin@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > diff --git a/arch/arm64/include/asm/vmalloc.h b/arch/arm64/include/asm/vmalloc.h > index 2ca708ab9b20..597b40405319 100644 > --- a/arch/arm64/include/asm/vmalloc.h > +++ b/arch/arm64/include/asm/vmalloc.h > @@ -1,4 +1,12 @@ > #ifndef _ASM_ARM64_VMALLOC_H > #define _ASM_ARM64_VMALLOC_H > > +#include > + > +#ifdef CONFIG_HAVE_ARCH_HUGE_VMAP > +bool arch_vmap_p4d_supported(pgprot_t prot); > +bool arch_vmap_pud_supported(pgprot_t prot); > +bool arch_vmap_pmd_supported(pgprot_t prot); > +#endif Shouldn't the be inlines or macros? Also it would be useful if the architectures would not have to override all functions but just those that are it actually implements? Also lots of > 80 char lines in the patch.