From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F81C433DB for ; Sun, 24 Jan 2021 11:33:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C45DD22C9F for ; Sun, 24 Jan 2021 11:33:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C45DD22C9F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 03D6F6B0007; Sun, 24 Jan 2021 06:33:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0137C6B0008; Sun, 24 Jan 2021 06:33:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E935C6B000A; Sun, 24 Jan 2021 06:33:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id D44DA6B0007 for ; Sun, 24 Jan 2021 06:33:36 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9A3768249980 for ; Sun, 24 Jan 2021 11:33:36 +0000 (UTC) X-FDA: 77740458432.22.smile84_1216a3d2757c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 74BA318038E67 for ; Sun, 24 Jan 2021 11:33:36 +0000 (UTC) X-HE-Tag: smile84_1216a3d2757c X-Filterd-Recvd-Size: 2425 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Sun, 24 Jan 2021 11:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ACB8L1iH4Gc89YVix2D94YMUoC0lAHVoOtd7z7k4gbA=; b=UvTPXRec/KKC/vVCNhylGppLtA 4gnsAaSCRXS7ZbiRj/1I81m2v5V7rxONcoEdtCoTFbPhgDZHWqhrqlE3hNoqnsm4OjM4RIo1+mhj2 xdDThKzazfQmoaRm+CLVmPbdK+gi8y9nPSLzzgyA1jT+QjKm/0TTUCyPSND4zTKk/B1SFxUeDz2jC f44ediPoO5ZYs0CTAUMJUfXGkYxtD7rJ7IKWEa949RJ/6cdBlTeMd1I6z1Rp/78jzVhU+4RJot1/1 bh3jTbubINajUJMB3xYPQI7D2cCbRTPnaHaGbhM/WhVXvHl4MRmeQ9Hyuu5O9hcbDD+uBJhA7Lxyd zddL0biA==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l3ddB-002ufv-2n; Sun, 24 Jan 2021 11:32:39 +0000 Date: Sun, 24 Jan 2021 11:32:33 +0000 From: Christoph Hellwig To: Nicholas Piggin Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Zefan Li , Jonathan Cameron , Christoph Hellwig , Christophe Leroy , Rick Edgecombe , Ding Tianhong Subject: Re: [PATCH v10 02/12] mm: apply_to_pte_range warn and fail if a large pte is encountered Message-ID: <20210124113233.GB694255@infradead.org> References: <20210124082230.2118861-1-npiggin@gmail.com> <20210124082230.2118861-3-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210124082230.2118861-3-npiggin@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 24, 2021 at 06:22:20PM +1000, Nicholas Piggin wrote: > apply_to_pte_range might mistake a large pte for bad, or treat it as a > page table, resulting in a crash or corruption. Add a test to warn and > return error if large entries are found. Looks good, Reviewed-by: Christoph Hellwig