From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A781C433E0 for ; Sun, 24 Jan 2021 04:08:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3CEA422C7B for ; Sun, 24 Jan 2021 04:08:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CEA422C7B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 76D946B0005; Sat, 23 Jan 2021 23:08:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F40C6B0007; Sat, 23 Jan 2021 23:08:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E3D26B0008; Sat, 23 Jan 2021 23:08:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id 43D306B0005 for ; Sat, 23 Jan 2021 23:08:13 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 07FF5180AD837 for ; Sun, 24 Jan 2021 04:08:13 +0000 (UTC) X-FDA: 77739336066.30.bait27_0f053a52757a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id D5BAE180B45BE for ; Sun, 24 Jan 2021 04:08:12 +0000 (UTC) X-HE-Tag: bait27_0f053a52757a X-Filterd-Recvd-Size: 1817 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Sun, 24 Jan 2021 04:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Lh9eOrCOK7bXOzdecd6q2dREsDMbVoNPQCAm58V7l6Y=; b=lFpoumH943oCQgcXSCsz6hp9Vg A8tXsciyoS3o/ZjeYJBZT3wxlqR+eKL9W2vX+yOhsMIUz9F83RmCkjlMlxwU1GYzaHe8mZg42jCfC 8o21uJxrNQWLI4UB6qU1kUNvP8xwsOG7rJr/TQS32mMJaDalZBXCDl0OuBrk5JB6S632Vn5IKfntJ FvrNqXtnqTAYqbR5LfpD2YDa6E7JrGZEtX/vwH2uJgsuoS6lUqDljt5rVJkf7364eKYLtLlw+8fk+ /2nXegCxdGvZH7QgtD6DGEr6LX3hOa1qGXo6mCe7dp1gBgqlQ14iAezJ7DmDuKl7CyygxjC5FmJJj 1FoC36PQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l3Wfw-002abG-77; Sun, 24 Jan 2021 04:07:14 +0000 Date: Sun, 24 Jan 2021 04:06:56 +0000 From: Matthew Wilcox To: Stephen Zhang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memfd: replace strcpy() by strscpy() Message-ID: <20210124040656.GB308988@casper.infradead.org> References: <1611455017-2210-1-git-send-email-stephenzhangzsd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1611455017-2210-1-git-send-email-stephenzhangzsd@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 24, 2021 at 10:23:37AM +0800, Stephen Zhang wrote: > - strcpy(name, MFD_NAME_PREFIX); > + strscpy(name, MFD_NAME_PREFIX, len + MFD_NAME_PREFIX_LEN); This is silly. Use memcpy() if you must remove strcpy.