From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDCB0C433DB for ; Sun, 24 Jan 2021 03:55:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 37161225AB for ; Sun, 24 Jan 2021 03:55:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37161225AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF84E6B0005; Sat, 23 Jan 2021 22:55:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EAA2D6B0007; Sat, 23 Jan 2021 22:55:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D97E46B0008; Sat, 23 Jan 2021 22:55:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id C03976B0005 for ; Sat, 23 Jan 2021 22:55:46 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 844A71EE6 for ; Sun, 24 Jan 2021 03:55:46 +0000 (UTC) X-FDA: 77739304692.04.ray78_5f02e1c2757a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 678AF80048FB for ; Sun, 24 Jan 2021 03:55:46 +0000 (UTC) X-HE-Tag: ray78_5f02e1c2757a X-Filterd-Recvd-Size: 4790 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Sun, 24 Jan 2021 03:55:45 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id d4so5583279plh.5 for ; Sat, 23 Jan 2021 19:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z8p1cg791IOBOg3jouOVxKLCS8JU3pUKCWAsXYCDxgI=; b=UCNNe9kx0Ck4ws+JZLocZVaYyR9CzLndNEwHP4d/f0iTmfrHyWyrlRajbyQNKxHeiK EYNQiLW6pzSIu2IfF9qaGBAWxJGGVx0mnhMnl9xINER3PcKTLciyPbdu2OMdDnTfVb3k Y7L5qpv3LfMUYtjGuXhxs37hBuKxNCGiNnlWcCN8bZ/eKbxTWOoUgKc6XFPzEnf2Wz/9 iNlVYP4x0xePEcz5UiKjPrq9V9cknltFoxIMH8iJUfCL26hFnxOAl/byovqNNwjAvnY5 Ec4xv53dsXMThbIzX5MOpGwR6lU/oVc3W7woQq6r2kPI0x1YVWQzleNWgALMqrtq7lNu XMuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z8p1cg791IOBOg3jouOVxKLCS8JU3pUKCWAsXYCDxgI=; b=NZORJohe/BCe3IyxkMET1sPLGvNkQc+gAThjcZEbNbgbW2COFdHY2YWIL22phLc12b hU0lqseL34ZtkAECT0J+iygaPCLkmQS1YekNOuFWwb5W12ongfId4cmbQMLHtRfucLSx gC0UfbE9xDK3q9KGc1alruRX0m3OI4tkWNsoWZmQvnLkC7fB9OoubX4KJpuyZqMMiv1o ps8elWBJlnWnxyWHuc8I6q39amqmMnMBQl/ivjXRFbG4EAapLUVx6LMz+4YugwcOgLUK greQK7yPnAjP3C/eE8kYjjUi7jeQVzp48mELmFELeUoxGUraNJd3x3SMO4MrpFWRjUGK Q3mA== X-Gm-Message-State: AOAM531iprgsk913dr5l9rawbjJKDcLPOM+S3ey+XndrzFDW539R2eWa 7Qpn2yeqObuklCWhYNDsAXs= X-Google-Smtp-Source: ABdhPJwanmAlLJIpD8jP4uoNu2T6M4tcckDPZvRCwSygRktuz/P9JcfrTj98//etmkRd1xobZtam5A== X-Received: by 2002:a17:902:c394:b029:df:e6bf:79b1 with SMTP id g20-20020a170902c394b02900dfe6bf79b1mr2039053plg.68.1611460545177; Sat, 23 Jan 2021 19:55:45 -0800 (PST) Received: from pek-khao-d2.corp.ad.wrs.com (unknown-105-121.windriver.com. [147.11.105.121]) by smtp.gmail.com with ESMTPSA id d4sm499083pgq.32.2021.01.23.19.55.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jan 2021 19:55:42 -0800 (PST) Date: Sun, 24 Jan 2021 11:55:35 +0800 From: Kevin Hao To: Jakub Kicinski Cc: "David S . Miller" , Andrew Morton , netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next 1/4] mm: page_frag: Introduce page_frag_alloc_align() Message-ID: <20210124035535.GA635475@pek-khao-d2.corp.ad.wrs.com> References: <20210123115903.31302-1-haokexin@gmail.com> <20210123115903.31302-2-haokexin@gmail.com> <20210123125221.528cd9e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline In-Reply-To: <20210123125221.528cd9e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 23, 2021 at 12:52:21PM -0800, Jakub Kicinski wrote: > On Sat, 23 Jan 2021 19:59:00 +0800 Kevin Hao wrote: > > +void *page_frag_alloc(struct page_frag_cache *nc, > > + unsigned int fragsz, gfp_t gfp_mask) > > +{ > > + return page_frag_alloc_align(nc, fragsz, gfp_mask, 0); > > +} > > EXPORT_SYMBOL(page_frag_alloc); >=20 > Isn't it better to make this a static inline now? Sure. I will also inline the {netdev,napi}_alloc_frag(). >=20 > Either way you'll need to repost after net is merged into net-next > (probably ~this Friday), please mark the posting as RFC before that. Sorry, I missed that. I will repost after the net is merged into net-next. > Please make sure you CC the author of the code. Will do. Thanks, Kevin --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEHc6qFoLCZqgJD98Zk1jtMN6usXEFAmAM77cACgkQk1jtMN6u sXGy2Af/esvxzz8KVpoRfQPATJGzjAOAB3UmuDILJIYMb494FT1wfOKwV9D1WIpr ekX94Ax36bX2WAy9yzeJhSOUNJlmDJuNt7BQgfv+0VwF9xH/F0lQaxoChnbkb7TW GYHaUXyN/yWMH8Vdfz9C3OLfpBCcjQEfinGW5v/hzGNnWWNwfjYVIX95Kh4b9AXJ rbdrQsaiGEpG+7krlZiyoNn3bpAM5bOmcYwAZ/Ryhn2dQ/Qoa3MXpNFj0i3BC4kA NNKeKZvc+DBcixnyNHKgupDa48kHBqTAYaqRdA855hS3Jmnub1LPDf4/yySk5zph fjozo+EKQunm1KxxrsfqlFW1Xtn2BA== =Bek2 -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--