From: Kevin Hao <haokexin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH net-next 1/4] mm: page_frag: Introduce page_frag_alloc_align()
Date: Sun, 24 Jan 2021 11:55:35 +0800 [thread overview]
Message-ID: <20210124035535.GA635475@pek-khao-d2.corp.ad.wrs.com> (raw)
In-Reply-To: <20210123125221.528cd9e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On Sat, Jan 23, 2021 at 12:52:21PM -0800, Jakub Kicinski wrote:
> On Sat, 23 Jan 2021 19:59:00 +0800 Kevin Hao wrote:
> > +void *page_frag_alloc(struct page_frag_cache *nc,
> > + unsigned int fragsz, gfp_t gfp_mask)
> > +{
> > + return page_frag_alloc_align(nc, fragsz, gfp_mask, 0);
> > +}
> > EXPORT_SYMBOL(page_frag_alloc);
>
> Isn't it better to make this a static inline now?
Sure. I will also inline the {netdev,napi}_alloc_frag().
>
> Either way you'll need to repost after net is merged into net-next
> (probably ~this Friday), please mark the posting as RFC before that.
Sorry, I missed that. I will repost after the net is merged into net-next.
> Please make sure you CC the author of the code.
Will do.
Thanks,
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-24 3:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 11:58 [PATCH net-next 0/4] net: Avoid the memory waste in some Ethernet drivers Kevin Hao
2021-01-23 11:59 ` [PATCH net-next 1/4] mm: page_frag: Introduce page_frag_alloc_align() Kevin Hao
2021-01-23 20:52 ` Jakub Kicinski
2021-01-24 3:55 ` Kevin Hao [this message]
2021-01-26 16:19 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124035535.GA635475@pek-khao-d2.corp.ad.wrs.com \
--to=haokexin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox