From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA35DC433E0 for ; Sat, 23 Jan 2021 20:52:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1FBA122CAF for ; Sat, 23 Jan 2021 20:52:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FBA122CAF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0F9396B0005; Sat, 23 Jan 2021 15:52:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AA1C6B0007; Sat, 23 Jan 2021 15:52:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F00906B0008; Sat, 23 Jan 2021 15:52:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id DA1AF6B0005 for ; Sat, 23 Jan 2021 15:52:24 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9F9173647 for ; Sat, 23 Jan 2021 20:52:24 +0000 (UTC) X-FDA: 77738237808.02.cows14_4b0dc7727577 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 7778A10097AA0 for ; Sat, 23 Jan 2021 20:52:24 +0000 (UTC) X-HE-Tag: cows14_4b0dc7727577 X-Filterd-Recvd-Size: 2048 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Sat, 23 Jan 2021 20:52:24 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id AE9DC22CA0; Sat, 23 Jan 2021 20:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611435142; bh=879HMQITkOOhgY0AwLQC/xU742SNiNTRIKQGUflXl1k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SyAXmYNcxiGldVjkkrAfjoc2LK+vMSSA3Wq/pfImnJpRV0hW9VxM9QUAeL6skBxjH jiryOo/eNTb1pRDR87BSOCCA6Hb6YbQOXXSuSUK4kZcA/XJPhcSG3GBiduSGN2B3NO sAddDhw1TEM/UuH6keKIbVr8HEyaAo3v10caYA5Oc4AXY8ow4hX3nw3CYRLnI1s9Xq zWBI9sswTDlYwxJDZZQpvJf5D07fV+n1YJR21HIJbZVjxEFuNy1cZrU9V8X9FA7wAo AJPCK0IcCHIT2MNQWMwGxsHyWtgee9vWgqXishBomUkxgvgpY51TL64jXG478yLlkl MoDsIyTztBZzQ== Date: Sat, 23 Jan 2021 12:52:21 -0800 From: Jakub Kicinski To: Kevin Hao Cc: "David S . Miller" , Andrew Morton , netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next 1/4] mm: page_frag: Introduce page_frag_alloc_align() Message-ID: <20210123125221.528cd9e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210123115903.31302-2-haokexin@gmail.com> References: <20210123115903.31302-1-haokexin@gmail.com> <20210123115903.31302-2-haokexin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 23 Jan 2021 19:59:00 +0800 Kevin Hao wrote: > +void *page_frag_alloc(struct page_frag_cache *nc, > + unsigned int fragsz, gfp_t gfp_mask) > +{ > + return page_frag_alloc_align(nc, fragsz, gfp_mask, 0); > +} > EXPORT_SYMBOL(page_frag_alloc); Isn't it better to make this a static inline now? Either way you'll need to repost after net is merged into net-next (probably ~this Friday), please mark the posting as RFC before that. Please make sure you CC the author of the code.