From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FCDAC433E0 for ; Fri, 22 Jan 2021 18:12:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E307123A9C for ; Fri, 22 Jan 2021 18:12:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E307123A9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3023B6B0005; Fri, 22 Jan 2021 13:12:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B40B6B0007; Fri, 22 Jan 2021 13:12:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F0566B0008; Fri, 22 Jan 2021 13:12:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 096476B0005 for ; Fri, 22 Jan 2021 13:12:17 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BACAD1E19 for ; Fri, 22 Jan 2021 18:12:16 +0000 (UTC) X-FDA: 77734205472.09.meal97_320381c2756d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id A0BDF1809321B for ; Fri, 22 Jan 2021 18:12:16 +0000 (UTC) X-HE-Tag: meal97_320381c2756d X-Filterd-Recvd-Size: 3229 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Fri, 22 Jan 2021 18:12:16 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 36AC623AA1; Fri, 22 Jan 2021 18:12:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611339135; bh=H6L86AoTyE/hqmip5biwOJIAV+COzy3z1pHTxe6CyKo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bOzCO5VcEuc+6C7UFnok8XLPyEJ2/Tq5ZFVSvPY+N6mWPSG1/zaluhDnCTdpM1jfx OOnJ2lZWbI7xBcU3gL+CPDN2WbA7I4eFr3e+LeJI075kWgB+NJtL5bw3nje1llmxXF aC6Rbiv6HFEnYG9BnIEyWvMDKCo9zdTLTD63s4UAbpWOSzkC3CiIpygK2GVOXX4DRJ CsANkW4CNVmJITDaNlpAoo7SYLF0MovPyE4SgYVmOLl2epMgnbvw1VqmwMleYCja6r erHqZsQZxhoVDp83eNVnXU0ryjL6ssuZU4qNd4o/1h6t56X5rEe0RMh+2GQKG4w4sK Ktk3bL7vGjysg== Date: Fri, 22 Jan 2021 20:12:09 +0200 From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, lkp@intel.com Subject: Re: [PATCH v5 0/5] mm: clean up names and parameters of memmap_init_xxxx functions Message-ID: <20210122181209.GD6332@kernel.org> References: <20210122135956.5946-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210122135956.5946-1-bhe@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 22, 2021 at 09:59:51PM +0800, Baoquan He wrote: > This patchset is correcting inappropriate function names of > memmap_init_xxx, and simplify parameters of functions in the code flow. > And also fix a prototype warning reported by lkp. > > This is based on the latest next/master. > > V4 can be found here: > https://lore.kernel.org/linux-mm/20210120045213.6571-1-bhe@redhat.com/ > > v4->v5: > - Add patch 1 into series which fixes a prototype warning from kernel > test robot. Then rebase the v4 patches on top of it. > > v3->v4: > - Rebased patch 1, 2 on top of Mike's below new patch. > [PATCH v3 0/2] mm: fix initialization of struct page for holes in memory layout > > - Move the code of renaming function parameter 'range_start_pfn' and local > variable 'range_end_pfn' of memmap_init() from patch 1 to patch 2 > according to David's comment. > > - Use the reverse Christmas tree style to reorder the local variables > in memmap_init_zone() in patch 2 accodrding to David's comment. > > Baoquan He (5): > mm: fix prototype warning from kernel test robot > mm: rename memmap_init() and memmap_init_zone() > mm: simplify parater of function memmap_init_zone() > mm: simplify parameter of setup_usemap() > mm: remove unneeded local variable in free_area_init_core For the series: Reviewed-by: Mike Rapoport > > arch/ia64/include/asm/pgtable.h | 6 ----- > arch/ia64/mm/init.c | 14 +++++----- > include/linux/mm.h | 3 ++- > mm/memory_hotplug.c | 2 +- > mm/page_alloc.c | 46 ++++++++++++++------------------- > 5 files changed, 31 insertions(+), 40 deletions(-) > > -- > 2.17.2 > -- Sincerely yours, Mike.