From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3605AC433E0 for ; Thu, 21 Jan 2021 08:39:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B63FE2399C for ; Thu, 21 Jan 2021 08:39:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B63FE2399C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0507E6B0025; Thu, 21 Jan 2021 03:39:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 000A46B0026; Thu, 21 Jan 2021 03:39:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0B1A8D0001; Thu, 21 Jan 2021 03:39:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id C87C26B0025 for ; Thu, 21 Jan 2021 03:39:49 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 94CDB3631 for ; Thu, 21 Jan 2021 08:39:49 +0000 (UTC) X-FDA: 77729134098.17.top54_3b0b67e27561 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 75959180D0180 for ; Thu, 21 Jan 2021 08:39:49 +0000 (UTC) X-HE-Tag: top54_3b0b67e27561 X-Filterd-Recvd-Size: 2253 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Jan 2021 08:39:48 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id F231723788; Thu, 21 Jan 2021 08:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611218387; bh=qDto+hNonlN+kjNPlMA/r46apQgOCJ/fpSbjSihzh6U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YsPwMdOHGSSe82eHKu7Qlmh8sCQdcslYS3Tm+il/iwas54Vyz29XCjWg9FCwNbRxt /u3NqqwNENCVXXwmMI+o3MNYJxojXRAdWdXZj71g5PEa+AX7qDrjdvinmSK/bBYO5m pRJott3FuCqrKOFbyoyPQx/GQNDHVcZUEnD0HO5WXmiLr2o+Ml0Gye+as3PpQnRXvs bhtl0itmSM6pqaq73HurDLrjPLnabrE8tTHn97gnBz9NZ5LIUAXizgDF5vwpne9enX evpNW1F7ZwJTLFih8jCAqM03VfOwl6IAMIdIdpKDRQXU/r3DplbZuzsscNnkSDtORq cHVk1larMnwXA== Date: Thu, 21 Jan 2021 10:39:42 +0200 From: Mike Rapoport To: Yun Levi Cc: David Hildenbrand , Andrew Morton , linux-mm@kvack.org, inux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memblock: Fix the typo on comments. Message-ID: <20210121083942.GT1106298@kernel.org> References: <20210120122818.GA34342@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 21, 2021 at 08:43:20AM +0900, Yun Levi wrote: > > subject would be clearer as something like > > > > "mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid()" > > > > Reviewed-by: David Hildenbrand > > Thanks. Then, should I resend this patch with suggested subject with > Reviewed-by tag? In general, yes. When there are minor review comments and Reviewed-by tag, you should send v2 version of a patch that addresses the comments and has the Reviewed-by tag. Since this is a small patch and a small update, I've applied the patch with the subject David suggested to memblock/fixes branch. -- Sincerely yours, Mike.