From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B0DC433DB for ; Thu, 21 Jan 2021 07:32:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D4699238E2 for ; Thu, 21 Jan 2021 07:32:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4699238E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2FFBB6B000A; Thu, 21 Jan 2021 02:32:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B13E6B000C; Thu, 21 Jan 2021 02:32:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 178566B000E; Thu, 21 Jan 2021 02:32:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id 0186D6B000A for ; Thu, 21 Jan 2021 02:32:11 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BC534181AEF3E for ; Thu, 21 Jan 2021 07:32:11 +0000 (UTC) X-FDA: 77728963662.26.sugar66_041660627561 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 9BE361804B670 for ; Thu, 21 Jan 2021 07:32:11 +0000 (UTC) X-HE-Tag: sugar66_041660627561 X-Filterd-Recvd-Size: 1336 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Jan 2021 07:32:11 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 6161A68B05; Thu, 21 Jan 2021 08:32:09 +0100 (CET) Date: Thu, 21 Jan 2021 08:32:09 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH v4 11/18] mm/filemap: Convert filemap_update_page to return an errno Message-ID: <20210121073209.GE23583@lst.de> References: <20210121041616.3955703-1-willy@infradead.org> <20210121041616.3955703-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121041616.3955703-12-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 21, 2021 at 04:16:09AM +0000, Matthew Wilcox (Oracle) wrote: > Use AOP_TRUNCATED_PAGE to indicate that no error occurred, but the > page we looked up is no longer valid. In this case, the reference > to the page will have been removed; if we hit any other error, the > caller will release the reference. Looks good, Reviewed-by: Christoph Hellwig