From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99696C433DB for ; Wed, 20 Jan 2021 08:27:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D39C52251D for ; Wed, 20 Jan 2021 08:27:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D39C52251D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kingsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3307F6B0005; Wed, 20 Jan 2021 03:27:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B8286B0006; Wed, 20 Jan 2021 03:27:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 180826B0007; Wed, 20 Jan 2021 03:27:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id F298D6B0005 for ; Wed, 20 Jan 2021 03:27:15 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A6BC8180AD806 for ; Wed, 20 Jan 2021 08:27:15 +0000 (UTC) X-FDA: 77725473630.17.straw82_00118c627559 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 84DB5180D0181 for ; Wed, 20 Jan 2021 08:27:15 +0000 (UTC) X-HE-Tag: straw82_00118c627559 X-Filterd-Recvd-Size: 4261 Received: from mail.kingsoft.com (unknown [114.255.44.146]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 Jan 2021 08:27:12 +0000 (UTC) X-AuditID: 0a580155-713ff700000550c6-24-6007e363ba7f Received: from mail.kingsoft.com (localhost [10.88.1.32]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.kingsoft.com (SMG-2-NODE-85) with SMTP id E0.EE.20678.363E7006; Wed, 20 Jan 2021 16:01:39 +0800 (HKT) Received: from aili-OptiPlex-7020 (172.16.253.254) by KSBJMAIL2.kingsoft.cn (10.88.1.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 20 Jan 2021 16:27:02 +0800 Date: Wed, 20 Jan 2021 16:27:02 +0800 From: Aili Yao To: "HORIGUCHI =?UTF-8?B?TkFPWUE=?=(=?UTF-8?B?5aCA5Y+j44CA55u05Lmf?=)" CC: "linux-mm@kvack.org" , "osalvador@suse.de" , "YANGFENG1@kingsoft.com" Subject: Re: [PATCH v4] mm,hwpoison: Differentiate Action Required error in current and non current processes Message-ID: <20210120162702.1285bb99.yaoaili@kingsoft.com> In-Reply-To: <20210120075923.GA30851@hori.linux.bs1.fc.nec.co.jp> References: <20210120150302.2bd277e3.yaoaili@kingsoft.com> <20210120075923.GA30851@hori.linux.bs1.fc.nec.co.jp> Organization: Kingsoft X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.16.253.254] X-ClientProxiedBy: KSBJMAIL1.kingsoft.cn (10.88.1.31) To KSBJMAIL2.kingsoft.cn (10.88.1.32) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrALMWRmVeSWpSXmKPExsXCFcGooJv8mD3BYOV+NYt7a/6zWlxsPMBo cWZakQOzx6ZPk9g9XlzdyOKx+XR1AHMUl01Kak5mWWqRvl0CV8aRNU/YCl5xV7TfmM/YwLiM s4uRk0NCwETi59xWpi5GLg4hgelMEsf6PkM5LxglLhzYB+RwcLAIqEpca8gEaWADMnfdm8UK YosIJEksnv2VCcRmFuhmlFjwUg6kXFigQGLqNSWQMK+AlcT6N81sIDangKPEnYt9YLaQQKHE lIW32EHK+QXEJF41GEOcYy/x/O9ZZohWQYmTM5+wQEzXlGjd/psdwtaWWLbwNTPEGEWJw0t+ sUP0Kkkc6Z7BBmHHSiyb94p1AqPwLCSjZiEZNQvJqAWMzKsYWYpz0402MUICOXQH44ymj3qH GJk4GA8xSnAwK4nwNv1lSxDiTUmsrEotyo8vKs1JLT7EKM3BoiTO2+IElBJITyxJzU5NLUgt gskycXBKNTCdmRtlvS646/Pk1Yc7W17OvZfK+J0/edGRp21TTe1+ejlwpL3f+NZQkS1qntVV dr89O1fpm/t/aKn0Uf9awxdXMXu6dHvid1HJAxu7yzwELlyazanidiWUpUp0/YK9JRuiv7/z UOo3OndM13zbRR7f0KNbDj9dztAumLPU7Vhyl/vj60E7thvGRWxa1nl6q+/eA+dr969mv6my ULtDNLW0zoRVZM7Lh3M5Hqn61ntFTAierRKR8LW3eN1j/U8Sa693FShmGx7g4Hya+dRCrU+3 N/P8nVtPbafzaxtKaFQFX+KZ1tdcvLp76eeU+0urU2dY7bktzL7gvr3S6bSLktfP8zQxi7a0 dj4SLmFmt1ZiKc5INNRiLipOBABO7WvM0wIAAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.035611, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 20 Jan 2021 07:59:23 +0000 HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3=E3=80=80=E7=9B=B4=E4=B9=9F) wrote: > It's desirable that $SUBJECT represents what that patch does, so > how about something like > "mm, hwpoison: send SIGBUS to PF_MCE_EARLY processes on action required e= vents" ? This one looks better, i will change to that. Thanks > ... > > @@ -440,10 +443,13 @@ static struct task_struct *find_early_kill_thread= (struct task_struct *tsk) > > * Determine whether a given process is "early kill" process which exp= ects > > * to be signaled when some page under the process is hwpoisoned. > > * Return task_struct of the dedicated thread (main thread unless expl= icitly > > - * specified) if the process is "early kill," and otherwise returns NU= LL. > > + * specified) if the process is "early kill" and otherwise returns NUL= L. > > * > > - * Note that the above is true for Action Optional case, but not for A= ction > > - * Required case where SIGBUS should sent only to the current thread. > > + * Note that the above is true for Action Optional case. For Action Re= quired > > + * case, it's only meaningful to the current thread which need to be s= ignaled > > + * with SIGBUS, this error is Action Optional for other non current > > + * processes sharing the same error page,if the process is "early kill= ",the =20 >=20 Thanks for reminding, I will fix this in v5 patch Thank you! --=20 Best Regards! Aili Yao