From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69B95C433E0 for ; Wed, 20 Jan 2021 13:19:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DBB0723371 for ; Wed, 20 Jan 2021 13:19:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBB0723371 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 101446B0006; Wed, 20 Jan 2021 08:19:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 08A426B000A; Wed, 20 Jan 2021 08:19:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E955E6B000C; Wed, 20 Jan 2021 08:19:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id CDA566B0006 for ; Wed, 20 Jan 2021 08:19:41 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8E6821EE6 for ; Wed, 20 Jan 2021 13:19:41 +0000 (UTC) X-FDA: 77726210562.14.women69_450909c2755a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id F0F5B18229835 for ; Wed, 20 Jan 2021 13:19:40 +0000 (UTC) X-HE-Tag: women69_450909c2755a X-Filterd-Recvd-Size: 4402 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 Jan 2021 13:19:39 +0000 (UTC) Received: by mail-qv1-f53.google.com with SMTP id l7so10834891qvt.4 for ; Wed, 20 Jan 2021 05:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JuQvGRvkQQfVRzn/FUI+haarmzYqzGiLWBP9Je4qZPE=; b=QHJVd3T5Tsl7WmiiJ+h+AhTVu4iAWpt/4foFcd4/mjShCb05HeiGCXzKAj+Da/VDvV QqCbyDX+iw+0+XERIeP1O2cu/DekTw4hKakyJ638PzTcE2mQiR/oPwKEsyQv81ntuBUA IxtkYJu/+X8kTXcCLKn+qpX/46Ms6sZfYWWaIdX0MhJg6q5zRuogluR7m7+4GTW68pJy CNJzr2I+/7YWY6RRVTZNzBKAWMuIFxMbyHZqzIQbmdcme9ixdyOYyqXa3nCZnV08TVmf t1RQvZOApFqM68tMKYBli2pd1wrLaIUXypZac/PIJ2HSrwUtOfWNghJ1LMNXXysB4qCX 6JDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JuQvGRvkQQfVRzn/FUI+haarmzYqzGiLWBP9Je4qZPE=; b=Nb+mqD65oanHWTe8/JuuyynOzdGavTBGchmtf3yjW2Qm4+8NV1uB8jchTK4w8t7Lxz 95awPHoOZcAHD4hM3A9+tuuXq+ayFm5NQR4HYUUknSbOU31u6XXPUK9+KSQltIrrCYhJ G3LM+5tDXTQq6eB0+TVCAsyw8S3RFgoZ5v87Vr1oKm92F7Fqu/VKuRR0oFkK2cYLY+W7 P+09IBn5inHl6jlwvK+saE8pah1VCevUht71fXOTDhUwJnAXY+K/PY5oJ7KpE9mT1YGQ RRLkI6JyAJCWOswKY0EtqStOkAaQrEYvCbSe7+OE4+2OPGjsI1JB2alvQk1Cb6IntyKO Z9Xg== X-Gm-Message-State: AOAM5338Upn+3wUnCtJskPHBE1ZH/U8cljxg7o3JLeii9VHKGPSMyCBj qrVnFvL9N3O9DnXn/s2MYrIftg== X-Google-Smtp-Source: ABdhPJz4cQZ1YMTMG0FLUN0ZbA69O2/qIdTs4LRKLu+daL+1MgPSen3w52S63HZWxLilbEYISziQdA== X-Received: by 2002:a05:6214:1110:: with SMTP id e16mr9110666qvs.62.1611148779431; Wed, 20 Jan 2021 05:19:39 -0800 (PST) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id b67sm1249374qkc.44.2021.01.20.05.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jan 2021 05:19:38 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1l2DOb-004Tve-SU; Wed, 20 Jan 2021 09:19:37 -0400 Date: Wed, 20 Jan 2021 09:19:37 -0400 From: Jason Gunthorpe To: Pavel Tatashin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com, david@redhat.com, osalvador@suse.de, dan.j.williams@intel.com, sashal@kernel.org, tyhicks@linux.microsoft.com, iamjoonsoo.kim@lge.com, mike.kravetz@oracle.com, rostedt@goodmis.org, mingo@redhat.com, peterz@infradead.org, mgorman@suse.de, willy@infradead.org, rientjes@google.com, jhubbard@nvidia.com, linux-doc@vger.kernel.org, ira.weiny@intel.com, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v6 12/14] mm/gup: longterm pin migration cleaup Message-ID: <20210120131937.GG4605@ziepe.ca> References: <20210120014333.222547-1-pasha.tatashin@soleen.com> <20210120014333.222547-13-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210120014333.222547-13-pasha.tatashin@soleen.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 19, 2021 at 08:43:31PM -0500, Pavel Tatashin wrote: > When pages are longterm pinned, we must migrated them out of movable zone. > The function that migrates them has a hidden loop with goto. The loop is > to retry on isolation failures, and after successful migration. > > Make this code better by moving this loop to the caller. > > Signed-off-by: Pavel Tatashin > mm/gup.c | 88 +++++++++++++++++++++++--------------------------------- > 1 file changed, 36 insertions(+), 52 deletions(-) This looks OK, it is better Reviewed-by: Jason Gunthorpe I really dislike we always have to go over the page list twice in pin mode The is_pinnable_page() and LRU isolation should really be done inside __get_user_pages_locked() as each page is added to the output list But that is more of a larger issue than this series Jason