From: Jason Gunthorpe <jgg@ziepe.ca>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com,
david@redhat.com, osalvador@suse.de, dan.j.williams@intel.com,
sashal@kernel.org, tyhicks@linux.microsoft.com,
iamjoonsoo.kim@lge.com, mike.kravetz@oracle.com,
rostedt@goodmis.org, mingo@redhat.com, peterz@infradead.org,
mgorman@suse.de, willy@infradead.org, rientjes@google.com,
jhubbard@nvidia.com, linux-doc@vger.kernel.org,
ira.weiny@intel.com, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v6 12/14] mm/gup: longterm pin migration cleaup
Date: Wed, 20 Jan 2021 09:19:37 -0400 [thread overview]
Message-ID: <20210120131937.GG4605@ziepe.ca> (raw)
In-Reply-To: <20210120014333.222547-13-pasha.tatashin@soleen.com>
On Tue, Jan 19, 2021 at 08:43:31PM -0500, Pavel Tatashin wrote:
> When pages are longterm pinned, we must migrated them out of movable zone.
> The function that migrates them has a hidden loop with goto. The loop is
> to retry on isolation failures, and after successful migration.
>
> Make this code better by moving this loop to the caller.
>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
> mm/gup.c | 88 +++++++++++++++++++++++---------------------------------
> 1 file changed, 36 insertions(+), 52 deletions(-)
This looks OK, it is better
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
I really dislike we always have to go over the page list twice in pin
mode
The is_pinnable_page() and LRU isolation should really be done inside
__get_user_pages_locked() as each page is added to the output list
But that is more of a larger issue than this series
Jason
next prev parent reply other threads:[~2021-01-20 13:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 1:43 [PATCH v6 00/14] prohibit pinning pages in ZONE_MOVABLE Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 01/14] mm/gup: don't pin migrated cma pages in movable zone Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 02/14] mm/gup: check every subpage of a compound page during isolation Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 03/14] mm/gup: return an error on migration failure Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 04/14] mm/gup: check for isolation errors Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 05/14] mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_PIN Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 06/14] mm: apply per-task gfp constraints in fast path Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 07/14] mm: honor PF_MEMALLOC_PIN for all movable pages Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 08/14] mm/gup: do not migrate zero page Pavel Tatashin
2021-01-20 13:14 ` Jason Gunthorpe
2021-01-20 14:26 ` Pavel Tatashin
2021-01-25 14:28 ` Jason Gunthorpe
2021-01-25 15:38 ` Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 09/14] mm/gup: migrate pinned pages out of movable zone Pavel Tatashin
2021-01-20 17:50 ` kernel test robot
2021-01-20 21:31 ` Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 10/14] memory-hotplug.rst: add a note about ZONE_MOVABLE and page pinning Pavel Tatashin
2021-01-20 13:22 ` Jason Gunthorpe
2021-01-20 14:28 ` Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 11/14] mm/gup: change index type to long as it counts pages Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 12/14] mm/gup: longterm pin migration cleaup Pavel Tatashin
2021-01-20 13:19 ` Jason Gunthorpe [this message]
2021-01-20 14:17 ` Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 13/14] selftests/vm: test flag is broken Pavel Tatashin
2021-01-20 1:43 ` [PATCH v6 14/14] selftests/vm: test faulting in kernel, and verify pinnable pages Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120131937.GG4605@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=ira.weiny@intel.com \
--cc=jhubbard@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=mingo@redhat.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=tyhicks@linux.microsoft.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox