From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Daeho Jeong <daehojeong@google.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>,
Chao Yu <yuchao0@huawei.com>, Chao Yu <chao@kernel.org>
Subject: [kbuild] [linux-next:master 4203/4677] fs/f2fs/checkpoint.c:1851 f2fs_start_ckpt_thread() warn: passing zero to 'PTR_ERR'
Date: Wed, 20 Jan 2021 12:46:35 +0300 [thread overview]
Message-ID: <20210120094635.GE20820@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 2531 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 647060f3b592d3c8df0c85dd887557b03e6ea897
commit: b640eda3ba7ee210865f66e06aee62d0fbb9ce51 [4203/4677] f2fs: introduce checkpoint=merge mount option
config: arm-randconfig-m031-20210119 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
fs/f2fs/checkpoint.c:1851 f2fs_start_ckpt_thread() warn: passing zero to 'PTR_ERR'
Old smatch warnings:
fs/f2fs/f2fs.h:2227 __bitmap_ptr() warn: potential pointer math issue ('&ckpt->sit_nat_version_bitmap + offset' is a 32 bit pointer)
vim +/PTR_ERR +1851 fs/f2fs/checkpoint.c
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1839 int f2fs_start_ckpt_thread(struct f2fs_sb_info *sbi)
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1840 {
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1841 dev_t dev = sbi->sb->s_bdev->bd_dev;
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1842 struct ckpt_req_control *cprc = &sbi->cprc_info;
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1843
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1844 if (cprc->f2fs_issue_ckpt)
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1845 return 0;
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1846
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1847 cprc->f2fs_issue_ckpt = kthread_run(issue_checkpoint_thread, sbi,
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1848 "f2fs_ckpt-%u:%u", MAJOR(dev), MINOR(dev));
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1849 if (IS_ERR(cprc->f2fs_issue_ckpt)) {
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1850 cprc->f2fs_issue_ckpt = NULL;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
b640eda3ba7ee210 Daeho Jeong 2021-01-19 @1851 return PTR_ERR(cprc->f2fs_issue_ckpt);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
returning PTR_ERR(NULL) is success.
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1852 }
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1853
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1854 set_task_ioprio(cprc->f2fs_issue_ckpt, DEFAULT_CHECKPOINT_IOPRIO);
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1855
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1856 return 0;
b640eda3ba7ee210 Daeho Jeong 2021-01-19 1857 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30808 bytes --]
[-- Attachment #3: Type: text/plain, Size: 149 bytes --]
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
reply other threads:[~2021-01-20 9:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120094635.GE20820@kadam \
--to=dan.carpenter@oracle.com \
--cc=chao@kernel.org \
--cc=daehojeong@google.com \
--cc=jaegeuk@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=sj1557.seo@samsung.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox