From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 392D0C433E9 for ; Tue, 19 Jan 2021 18:28:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ACC0D22CAD for ; Tue, 19 Jan 2021 18:28:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACC0D22CAD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF7456B005D; Tue, 19 Jan 2021 13:28:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ECE4F6B006C; Tue, 19 Jan 2021 13:28:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D98106B006E; Tue, 19 Jan 2021 13:28:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id C48556B005D for ; Tue, 19 Jan 2021 13:28:27 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8E6BA180AD83B for ; Tue, 19 Jan 2021 18:28:27 +0000 (UTC) X-FDA: 77723359854.22.crack75_0d07a3727554 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 6B5D418038E67 for ; Tue, 19 Jan 2021 18:28:27 +0000 (UTC) X-HE-Tag: crack75_0d07a3727554 X-Filterd-Recvd-Size: 4149 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 Jan 2021 18:28:26 +0000 (UTC) Received: by mail-qt1-f180.google.com with SMTP id h19so14380112qtq.13 for ; Tue, 19 Jan 2021 10:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ke7qD8F84c1d4EOseUsfShNOeUs7V6JI/1ybkVdZuas=; b=XmQ0R0kZqyfx6kYtmKEuaQdnV3pA/Gk5AOzBRpiTYl4tlHVj1r8AGgHQ4HlCBrkqJq d3htfUs3a6Vo7BoCaKhfTS/pKV/wBzzmfP1qsXIQg8CQxxbNzgZLm/tv7iPsO1sHRvpU TCZW7i1jjllBwoa546R0ibB0zkSMqcrkOGwMgnllWMEUgURDH4T3uEK++bfZv7/+4pbj kS8q1ESLc1z39UecPfNCeUXmJIGhwHZBA/TwP+5YpJBnaym8fbHoGkHnHv5RdAWXulup dtDZh1pKug65yM1CA0ASf5OqBnSDmxdk7ota2wSPE6R9R/dxgH45I+bA7mqqlvFaweeD jp4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ke7qD8F84c1d4EOseUsfShNOeUs7V6JI/1ybkVdZuas=; b=QozaojXRNHMan4TOeU+4Zs9ATOUOiEKye5IKkbM2mVVW1GCr2Wox7xwYEJuvSU32/r VeuK2gjRuRnsFLEmMJ8IyZLaf+8PX9yJB0ZMsE4gUEqbxjsOHkGIOeqcbzWbRvlJ427a ExpHzXBB6iyc3V2hmwTBHFRn62pLTZNuYzri3He1xKyCtwXwiubPfQmavlwwS9wPX0Xz OEId4SEBOxcq0mz+MZh9x5ZzIZDzRosi1jnKYh/c6DdrNJTvtjIWTGM5BNg1Fwc8Zh9s yoqYECZv8vXX+mnI63uu5uEdLKm9/p8piDprMus7h4aMDGtfVVOHZEt9llw649gN2JE5 kR8A== X-Gm-Message-State: AOAM531+BUibMyzh+0x48vsi2MR4mpsRiEtnbxCKHfGlaT9O+Grb611z 8P2w66Il7RJTqrFFOit+9ali/w== X-Google-Smtp-Source: ABdhPJzA1g7p43l6AtNResDMMVS5o5wIwQMrXjddyfwRGWf3w+KrQJOMwx++nssqWWJKy8HjuEBVXA== X-Received: by 2002:ac8:2adb:: with SMTP id c27mr2484368qta.145.1611080906055; Tue, 19 Jan 2021 10:28:26 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id u5sm13640579qka.86.2021.01.19.10.28.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jan 2021 10:28:25 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1l1vjt-003pdK-4n; Tue, 19 Jan 2021 14:28:25 -0400 Date: Tue, 19 Jan 2021 14:28:25 -0400 From: Jason Gunthorpe To: Pavel Tatashin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com, david@redhat.com, osalvador@suse.de, dan.j.williams@intel.com, sashal@kernel.org, tyhicks@linux.microsoft.com, iamjoonsoo.kim@lge.com, mike.kravetz@oracle.com, rostedt@goodmis.org, mingo@redhat.com, peterz@infradead.org, mgorman@suse.de, willy@infradead.org, rientjes@google.com, jhubbard@nvidia.com, linux-doc@vger.kernel.org, ira.weiny@intel.com, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 03/14] mm/gup: return an error on migration failure Message-ID: <20210119182825.GA4605@ziepe.ca> References: <20210119043920.155044-1-pasha.tatashin@soleen.com> <20210119043920.155044-4-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210119043920.155044-4-pasha.tatashin@soleen.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 18, 2021 at 11:39:09PM -0500, Pavel Tatashin wrote: > When migration failure occurs, we still pin pages, which means > that we may pin CMA movable pages which should never be the case. > > Instead return an error without pinning pages when migration failure > happens. > > No need to retry migrating, because migrate_pages() already retries > 10 times. > > Signed-off-by: Pavel Tatashin > mm/gup.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) Reviewed-by: Jason Gunthorpe