From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73EDEC433E0 for ; Mon, 18 Jan 2021 08:15:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 81EA222525 for ; Mon, 18 Jan 2021 08:15:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81EA222525 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kingsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E9EC06B030A; Mon, 18 Jan 2021 03:15:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E275A6B0327; Mon, 18 Jan 2021 03:15:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEF146B0347; Mon, 18 Jan 2021 03:15:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id B5DFA6B030A for ; Mon, 18 Jan 2021 03:15:41 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7B529180AD830 for ; Mon, 18 Jan 2021 08:15:41 +0000 (UTC) X-FDA: 77718186882.19.tiger41_250cb9927547 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 5385E1ACC2B for ; Mon, 18 Jan 2021 08:15:41 +0000 (UTC) X-HE-Tag: tiger41_250cb9927547 X-Filterd-Recvd-Size: 4038 Received: from mail.kingsoft.com (unknown [114.255.44.146]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Jan 2021 08:15:38 +0000 (UTC) X-AuditID: 0a580155-ce01ea80000550c6-67-60053db57f1f Received: from mail.kingsoft.com (localhost [10.88.1.32]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.kingsoft.com (SMG-2-NODE-85) with SMTP id 23.B8.20678.5BD35006; Mon, 18 Jan 2021 15:50:13 +0800 (HKT) Received: from aili-OptiPlex-7020 (172.16.253.254) by KSBJMAIL2.kingsoft.cn (10.88.1.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 18 Jan 2021 16:15:12 +0800 Date: Mon, 18 Jan 2021 16:15:12 +0800 From: Aili Yao To: "HORIGUCHI =?UTF-8?B?TkFPWUE=?=(=?UTF-8?B?5aCA5Y+j44CA55u05Lmf?=)" CC: Oscar Salvador , "linux-mm@kvack.org" , "yangfeng1@kingsoft.com" Subject: Re: [PATCH] mm,hwpoison: non-current task should be checked early_kill for force_early Message-ID: <20210118161512.701c94e7.yaoaili@kingsoft.com> In-Reply-To: <20210118065054.GA7447@hori.linux.bs1.fc.nec.co.jp> References: <20210115155506.2d59fe83.yaoaili@kingsoft.com> <20210115084920.GA4092@linux> <20210115172622.699d68e5.yaoaili@kingsoft.com> <20210118051555.GA3585@hori.linux.bs1.fc.nec.co.jp> <20210118135744.7413cd06.yaoaili@kingsoft.com> <20210118065054.GA7447@hori.linux.bs1.fc.nec.co.jp> Organization: Kingsoft X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.16.253.254] X-ClientProxiedBy: KSBJMAIL1.kingsoft.cn (10.88.1.31) To KSBJMAIL2.kingsoft.cn (10.88.1.32) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrELMWRmVeSWpSXmKPExsXCFcGooLvVljXBYM4dSYt7a/6zWlxsPMBo cWZakQOzx6ZPk9g9XlzdyOKx+XR1AHMUl01Kak5mWWqRvl0CV8bH5U/YCx5yVLS+6GNsYGxk 72Lk5JAQMJG48fAyUxcjF4eQwHQmiRub97GAJIQEXjBKdH/x6GLk4GARUJV487cCJMwGZO66 N4sVxBYRSJJYPPsrWC+zQBujxJUdH5lAEsICiRLHJ+1jA7F5BawkHr9sYwSxOQUcJGa9uc4C sWwFk0Trp25mkAX8AmISrxqMIQ6yl3j+9ywzRK+gxMmZT8DuYRbQlGjd/psdwtaWWLbwNTPE nYoSh5f8gnpGSeJI9ww2CDtWYtm8V6wTGIVnIRk1C8moWUhGLWBkXsXIUpybbrSJERLMoTsY ZzR91DvEyMTBeIhRgoNZSYS3dB1TghBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHeuZ//xAsJpCeW pGanphakFsFkmTg4pRqYuDs6FwYcytrDrmDzez/fw0OrGBxCHMX6LeVl4sV1t81LEJ5mf/H7 RRG73xeOnOdWvRLRVO0dku00uVKmdcKBrROYK0TM9qzx2XMt4uX2X9f39DZ+u/Ob8S2Hcev5 KXNc2aJUc3weKH6MsEz91meQ7Z3leXOzs57I/Q/+3GX3qu5mnFt3qnW9ePDl09J3Dqn/Wptp U6yV3xz03XtbeKRn+J8f0gFuh2NCXNYo3KkRfW4sdXN+6rVzbO3pz21vx5kyXjk394u4j9WM 3Es/HCLEc4/N3FB9z6RJ8sGTCKlArhmHXldckpmgZ+9eW99tv5dl5hnRx/94p8SlHVs247Sb +cuLex9XWX3OXm59fMtdJZbijERDLeai4kQAEU1AIdUCAAA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.255745, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 18 Jan 2021 06:50:54 +0000 HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3=E3=80=80=E7=9B=B4=E4=B9=9F) wrote: >=20 > For action optional cases, one error event kills *only one* process. If an > error page are shared by multiple processes, these processes will be kill= ed > by separate error events, each of which is triggered when each process tr= ies > to access the error memory. So these processes would be killed immediate= ly > when accessing the error, but you don't have to kill all at the same time > (or actually you might not even have to kill it at all if the process exi= ts > finally without accessing the error later). >=20 > Maybe the function variable "force_early" is named confusingly (it sounds > that it's related to PF_MCE_KILL_EARLY flag, but that's incorrect). > I'll submit a fix later. (I'll add your "Reported-by" because you made me > find it, thank you.) >=20 I think we should do more for non current process error case, we should mar= k it AO for processes to be signaled or we may take wrong action. --=20 Best Regards! Aili Yao