From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80AEEC433E0 for ; Mon, 18 Jan 2021 10:09:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 15F5622211 for ; Mon, 18 Jan 2021 10:09:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15F5622211 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4F2A16B0012; Mon, 18 Jan 2021 05:09:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A2BA6B0115; Mon, 18 Jan 2021 05:09:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B7EA6B0132; Mon, 18 Jan 2021 05:09:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 239276B0012 for ; Mon, 18 Jan 2021 05:09:38 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B9B7B3623 for ; Mon, 18 Jan 2021 10:09:36 +0000 (UTC) X-FDA: 77718473952.15.night47_510b28727548 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 863E31814BA03 for ; Mon, 18 Jan 2021 10:09:36 +0000 (UTC) X-HE-Tag: night47_510b28727548 X-Filterd-Recvd-Size: 2472 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Jan 2021 10:09:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CEA43AB7A; Mon, 18 Jan 2021 10:09:34 +0000 (UTC) Date: Mon, 18 Jan 2021 11:09:32 +0100 From: Oscar Salvador To: Aili Yao Cc: HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+j44CA55u05LmfKQ==?= , "linux-mm@kvack.org" , "yangfeng1@kingsoft.com" Subject: Re: [PATCH] mm,hwpoison: non-current task should be checked early_kill for force_early Message-ID: <20210118100928.GA4988@linux> References: <20210115155506.2d59fe83.yaoaili@kingsoft.com> <20210115084920.GA4092@linux> <20210115172622.699d68e5.yaoaili@kingsoft.com> <20210118051555.GA3585@hori.linux.bs1.fc.nec.co.jp> <20210118135744.7413cd06.yaoaili@kingsoft.com> <20210118065054.GA7447@hori.linux.bs1.fc.nec.co.jp> <20210118161512.701c94e7.yaoaili@kingsoft.com> <20210118085747.GA904@hori.linux.bs1.fc.nec.co.jp> <20210118092419.GA4234@linux> <20210118173852.0c784aa9.yaoaili@kingsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210118173852.0c784aa9.yaoaili@kingsoft.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 18, 2021 at 05:38:52PM +0800, Aili Yao wrote: > On Mon, 18 Jan 2021 10:24:23 +0100 > Oscar Salvador wrote: > > > > > So, the scenario case is a multithread application with the same page mapped. > > And PF_MCE_KILL_EARLY flag was set. > > > The scenario is not related multithread application; > it's about multiprocess application which share the same page Ok, I misunderstood that part. Then, I do not fully understand the concern. I guess you are kind of memory scrubbing with mcelog defaulting to memory_failure instead of soft_offline. E.g: collect_procs_anon will pick the processes which have the MCE policy set and have the page mapped. That is all we should need. So, if you have processes A, B, C and D with X page mapped, and you set the MCE policy on those four, they should get picked up by your scrubbing when handling X page by memory_failure. Is not that right? -- Oscar Salvador SUSE L3