From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.6 required=3.0 tests=BAYES_00, CHARSET_FARAWAY_HEADER,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D11E1C433E0 for ; Mon, 18 Jan 2021 08:57:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3196C22228 for ; Mon, 18 Jan 2021 08:57:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3196C22228 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nec.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 586176B009C; Mon, 18 Jan 2021 03:57:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 537BC6B00CD; Mon, 18 Jan 2021 03:57:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3894C6B00D1; Mon, 18 Jan 2021 03:57:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id 1C1D16B009C for ; Mon, 18 Jan 2021 03:57:54 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D68A9181AEF2A for ; Mon, 18 Jan 2021 08:57:53 +0000 (UTC) X-FDA: 77718293226.24.desk64_380a81d27548 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id B34B91A4A5 for ; Mon, 18 Jan 2021 08:57:53 +0000 (UTC) X-HE-Tag: desk64_380a81d27548 X-Filterd-Recvd-Size: 9796 Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-eopbgr1400040.outbound.protection.outlook.com [40.107.140.40]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Jan 2021 08:57:50 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=goB2pgVkyH1e7QAU0FNWEZ4ptX+MjFLRoW/pvhnuMKE+vTux7GavlvfKuVArhVtHPGlzSzF4n3cKhGDg9lLyX42IPN6FvGf4eMPiEk1UbfxUkW39skVmjqYWyCUpYXrQraLZUk3ITkkt10PwLcfuVoElHKwIm0NVoIUlwLqfhAvsVf8yoTKZUECRXFyIY+a5FgN9lD0C4bTvJbMrzYcEU2tZKpIcQkwmR8gV+VGebGfxRLgsX3/mKOPQxGDFTkit5PNgGD8jOqpwzmMLY7pLFVYeC3XXpoDAx8hUc8GgwoWlMg3GdziG7jQ1pJbA/cnb9YjqUX76/0/QP7E6v70r6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZZOpDmlItBV7hKR2HxZ7Kk8o+Gym8vPMrXT+LJurB7I=; b=EqpFZOPSIUlq8YfMejPnEKbDbhBUW8DLcYFrrlC/aeZvsjtHukAovjLnrINlL+rt5SHdhSaVe+w7PfEY/k7Rfj3mXRhEPunbOyduUcjJrOYY+hnsSfrs8GBNVomNZw44GBkXWmFYO3KQi5zTDcCIMzw9BCP6qer5JolxQciChr6qZGTINl5G7HmEu6ENESMYevb3yN0J1rbz57+V8DZ4/VnPCPQoK48n68kuiNYGC7UN7GUSiP1kTTHabeSVbDzsJE4PW/HhUbu41NDHBiBWgWczqz7xS0hn0yJKoVllpzegMQcnZtDagKPLynHf4shl9DqieJqklUygyyqAozjtaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nec.com; dmarc=pass action=none header.from=nec.com; dkim=pass header.d=nec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nec.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZZOpDmlItBV7hKR2HxZ7Kk8o+Gym8vPMrXT+LJurB7I=; b=KQSj0c5x4XvIDxPM0e9zObmvvz/uTqvl6Dl/8CaBf47wHU9Q0YJKbUgK6/TQ0QUgvU4n2Vchk8QiPtriyY9sL9tzg7cRopFjXanHAgamK5BujGqMm3qSDfYya6khxGmzSE/IDo7lkBkzD3Y0uYNTDTXgvedkw0t3Tmzyb02hbUc= Received: from TY1PR01MB1852.jpnprd01.prod.outlook.com (2603:1096:403:8::12) by TYAPR01MB5931.jpnprd01.prod.outlook.com (2603:1096:404:805b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.11; Mon, 18 Jan 2021 08:57:47 +0000 Received: from TY1PR01MB1852.jpnprd01.prod.outlook.com ([fe80::8453:2ddb:cf2b:d244]) by TY1PR01MB1852.jpnprd01.prod.outlook.com ([fe80::8453:2ddb:cf2b:d244%7]) with mapi id 15.20.3763.013; Mon, 18 Jan 2021 08:57:47 +0000 From: =?iso-2022-jp?B?SE9SSUdVQ0hJIE5BT1lBKBskQktZOH0hIUQ+TGkbKEIp?= To: Aili Yao CC: Oscar Salvador , "linux-mm@kvack.org" , "yangfeng1@kingsoft.com" Subject: Re: [PATCH] mm,hwpoison: non-current task should be checked early_kill for force_early Thread-Topic: [PATCH] mm,hwpoison: non-current task should be checked early_kill for force_early Thread-Index: AQHW6xPOLHMPPWnvkk2J5KCsMbNbvqooYH4AgAAKVACABHEEgIAAC68AgAAO2wCAABeOAIAAC+aA Date: Mon, 18 Jan 2021 08:57:47 +0000 Message-ID: <20210118085747.GA904@hori.linux.bs1.fc.nec.co.jp> References: <20210115155506.2d59fe83.yaoaili@kingsoft.com> <20210115084920.GA4092@linux> <20210115172622.699d68e5.yaoaili@kingsoft.com> <20210118051555.GA3585@hori.linux.bs1.fc.nec.co.jp> <20210118135744.7413cd06.yaoaili@kingsoft.com> <20210118065054.GA7447@hori.linux.bs1.fc.nec.co.jp> <20210118161512.701c94e7.yaoaili@kingsoft.com> In-Reply-To: <20210118161512.701c94e7.yaoaili@kingsoft.com> Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kingsoft.com; dkim=none (message not signed) header.d=none;kingsoft.com; dmarc=none action=none header.from=nec.com; x-originating-ip: [165.225.110.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 369d2773-9129-4dce-b884-08d8bb8f20ba x-ms-traffictypediagnostic: TYAPR01MB5931: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AwxfumFC4Ed3KJ6Uw7+cpATdrENe8hbp3l8D6W40Lat1hToScSlQq9HMAbOxWA6M+bRAe5y1j5FZw+Uc/eG0M7EsKscqovQTeuNtEPUWMC5XJRD90W0DHEq+mVn+3MAFuNEUiXjHSKgAqQOBUjkdNNrSifaPrFXZSIa0VnVuv4HYQKmRO7gcvEwBVnNGfLNaaGrq8g9QbhPB1QCZ/x4UtmXuavdDkVqNpyPpXc2cnJo/+RH1kUIKSq4/wjBPkndhqj/uK/QkqDMk2/1sD74Q1THR2L5H0KieSY1Cwcg6VGhY1c2JPk29V9lEw+/TQx+nN9acp4a7nLcKZfQ2LexpK0S2JxrvVpxb0524pL3NGcTflsu6NkF+YRsHQPnbFqNuHCG4rZYlTBo4psNKwu3Gvg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY1PR01MB1852.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(136003)(376002)(39860400002)(366004)(1076003)(64756008)(66446008)(54906003)(76116006)(4326008)(8676002)(8936002)(55236004)(2906002)(478600001)(66946007)(6916009)(66556008)(66476007)(6506007)(6512007)(33656002)(9686003)(316002)(5660300002)(71200400001)(85182001)(6486002)(83380400001)(26005)(86362001)(186003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-2022-jp?B?RDNrMHpKTStqN25IM1NEc2V0L0FTMmlxOVBhQ0ZtNEg1YjJJM1FGY0xj?= =?iso-2022-jp?B?V2U2T0pVR3l6SXJVZU9xUVlObVRuN3hnbWlxLzRqbDlVVzluYzJtUjMz?= =?iso-2022-jp?B?RllWNStGYitsV2hmOVBCR05hVEx1RnF1WU5CZFh3eURxS2xNWWFnY3FW?= =?iso-2022-jp?B?VXNoNWNVbkxPaWRZR2pSRmxBZi84NHZLZEFSblA3VTc5ZTVvc2hKWDZH?= =?iso-2022-jp?B?d2xWOU9LRS9FTzU3dVJZanlYYnRvMHh6d1Q4anpLeW44c2JrZWVSMnZj?= =?iso-2022-jp?B?SHBUVmpINmZpN0Yvc2NDVENIaFA2NHlVM24rVHVMcVluaXlKZmFwOG1U?= =?iso-2022-jp?B?NkVtc1lmTzVocnBXL3ZtbXYxT2FNYWFxY2YzREZ2NE9VSVNuTVNSQTNB?= =?iso-2022-jp?B?WFRGL2dxYUlyc2NmZUY4SDRzbTlLREdZS2Rpem00ZDFmOTIra0ZQc1ll?= =?iso-2022-jp?B?bVJwWmVRMHIwdWpnZUZnNUh1dTI0eXlFMHJpY0VCTCtQcHlQYTJsaDk0?= =?iso-2022-jp?B?dnI2aFNVclJ2UnNPN1NQdGpzUVNGT3g3cFRxdmlWNlF4TzhFb1IxTTZt?= =?iso-2022-jp?B?bnFCTFdqM2sraGxhYUJKREg4Z0tkVU5GTTZTaUpGSndZdVJTUzdENk56?= =?iso-2022-jp?B?Lzg0Ni9sdVgrQm5GSTlBSWZxdnNRYXpYeWpaYnpuZkZ6clhhek9MQ2dS?= =?iso-2022-jp?B?K0lqM2JRNEs0YnpvTnpUbDhBOW9JWnpsblRINk51S25BaUdVVWJYeFhJ?= =?iso-2022-jp?B?VFB1SStzYkhLajVXVkV2YXIyRkZEMzA2QkNkZThsODVTcEVNbjlxQnNP?= =?iso-2022-jp?B?SUNFVEhNeUYwb1oyaWlSNXdEbVpXc3Jhd0pGaVRhZG1aNzVoQ3hhRW9r?= =?iso-2022-jp?B?MjRHd2xpWkJWeE5IeWcrcXFwTEJHRE9VZHFTRmJMNFNFWFdFQ3dpSjRW?= =?iso-2022-jp?B?TmxRYUxENXlLUkY4c3pieXJhaXk0a2tCQXZxZGRFdFdGMUUwbnY0Nngx?= =?iso-2022-jp?B?ZjhTbnIxSFpFejBDa2Q5L2JYbEt3VjJCMTdpalZBRjNQL2VnK1lZUjB2?= =?iso-2022-jp?B?TUg4NC9tVVVWVnc1UlFuQWRHMGVkcktnVjBvK3Q0eWJkQzl1T0Q0ZXdH?= =?iso-2022-jp?B?UzBlaEJ2bExkV2lGUVlsYktMQVd2dllBRzU3ZjkyM2N5eGhzVGlGU0RU?= =?iso-2022-jp?B?anlrRFZaLzhrMy9rQjQ5a01JR0JCSjMrTXpIMWdxeitlTGw2L1BuZld6?= =?iso-2022-jp?B?TEJPV1lUMEVtb3lZNWRwbXZ2WUhxYnlpTC9Ya2pxMTh3ZW50dHBKZUpM?= =?iso-2022-jp?B?NFBKV3NlTFRsZmxMbExwSkp2SzNQYy8wbG5ReWZiUlJQOGtwWFNCYjlU?= =?iso-2022-jp?B?UmJ6T0t3eXBmMUNycVNUL1d2SSsxNDhKaUFjUGlUeUVhcmdGbGUzbVBK?= =?iso-2022-jp?B?SzkvNHNYVThjYy8vcllYVg==?= Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <18B92147FCBB614DB93DA69F2CBA717C@jpnprd01.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY1PR01MB1852.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 369d2773-9129-4dce-b884-08d8bb8f20ba X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2021 08:57:47.5761 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e67df547-9d0d-4f4d-9161-51c6ed1f7d11 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3pz0Q48N8tRh1sgGntXCVwdM7C+/DiJYJ5NqAVREmuFMx7G8i4kW0VcANS2gAXeW/GWJ2aNas9O1WAZ4nSuMpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB5931 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000041, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 18, 2021 at 04:15:12PM +0800, Aili Yao wrote: > On Mon, 18 Jan 2021 06:50:54 +0000 > HORIGUCHI NAOYA(=1B$BKY8}!!D>Li=1B(B) wrote: >=20 > >=20 > > For action optional cases, one error event kills *only one* process. If= an > > error page are shared by multiple processes, these processes will be ki= lled > > by separate error events, each of which is triggered when each process = tries > > to access the error memory. So these processes would be killed immedia= tely > > when accessing the error, but you don't have to kill all at the same ti= me > > (or actually you might not even have to kill it at all if the process e= xits > > finally without accessing the error later). > >=20 > > Maybe the function variable "force_early" is named confusingly (it soun= ds > > that it's related to PF_MCE_KILL_EARLY flag, but that's incorrect). > > I'll submit a fix later. (I'll add your "Reported-by" because you made= me > > find it, thank you.) > >=20 > I think we should do more for non current process error case, we should m= ark it AO for processes to be signaled > or we may take wrong action. I'm not sure what you mean by "non current process error case" and "we should mark it AO", so could you explain more specifically about your error scenario? Especially I'd like to know about who triggers hard offline on what hardware events and what "wrong action" could happen. Maybe just "calling memory_failure() with MF_ACTION_REQUIRED" is not enough, because it's not enough for us to see that your scenario is possible. Current implementation implicitly assumes some hardware behavior, and does not work for the case which never happens under the assumption. Do you have some test cases to reproduce any specific issue (like data lost= ) on your system? (If yes, please share it.) Or your concern is from code rev= iew? Thanks, Naoya Horiguchi=