From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2564C433DB for ; Fri, 15 Jan 2021 09:26:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E6E423403 for ; Fri, 15 Jan 2021 09:26:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E6E423403 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kingsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E04B8D0147; Fri, 15 Jan 2021 04:26:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9686C8D0023; Fri, 15 Jan 2021 04:26:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857408D0147; Fri, 15 Jan 2021 04:26:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 6EA648D0023 for ; Fri, 15 Jan 2021 04:26:42 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 379EE815A for ; Fri, 15 Jan 2021 09:26:42 +0000 (UTC) X-FDA: 77707479444.05.match34_1c008022752e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 1A762180CE72B for ; Fri, 15 Jan 2021 09:26:42 +0000 (UTC) X-HE-Tag: match34_1c008022752e X-Filterd-Recvd-Size: 3668 Received: from mail.kingsoft.com (mail.kingsoft.com [114.255.44.145]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 09:26:37 +0000 (UTC) X-AuditID: 0a580157-f39ff7000005df43-f5-60015a9a1c5f Received: from mail.kingsoft.com (localhost [10.88.1.32]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.kingsoft.com (SMG-1-NODE-87) with SMTP id 60.18.57155.A9A51006; Fri, 15 Jan 2021 17:04:26 +0800 (HKT) Received: from aili-OptiPlex-7020 (172.16.253.254) by KSBJMAIL2.kingsoft.cn (10.88.1.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Fri, 15 Jan 2021 17:26:22 +0800 Date: Fri, 15 Jan 2021 17:26:22 +0800 From: Aili Yao To: Oscar Salvador CC: , , Subject: Re: [PATCH] mm,hwpoison: non-current task should be checked early_kill for force_early Message-ID: <20210115172622.699d68e5.yaoaili@kingsoft.com> In-Reply-To: <20210115084920.GA4092@linux> References: <20210115155506.2d59fe83.yaoaili@kingsoft.com> <20210115084920.GA4092@linux> Organization: Kingsoft X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.16.253.254] X-ClientProxiedBy: KSBJMAIL1.kingsoft.cn (10.88.1.31) To KSBJMAIL2.kingsoft.cn (10.88.1.32) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrELMWRmVeSWpSXmKPExsXCFcGooDsrijHB4OdueYt7a/6zWlxsPMBo cWZakQOzx6ZPk9g9XlzdyOKx+XR1AHMUl01Kak5mWWqRvl0CV8aKvXuYCk5zVFzddY2lgfEe WxcjJ4eEgInEjGl/mboYuTiEBKYzSZx4vZEdwnnBKHH3ehMTSBWLgKrE5t3v2EFsNiB7171Z rCC2iICaxLRXjWBxZgFfiSnrV4LVCwskShyftA9sA6+AlcT7l41g9ZwCWhLPZ91kBrGFBKIk 3pz6yNLFyMHBLyAm8arBGOIge4nnf88yQ7QKSpyc+YQFYryOxIlVx5ghbHmJ7W/nQI1RlDi8 5Bc7RK+SxJHuGVCPxUosm/eKdQKj8Cwko2YhGTULyagFjMyrGFmKc9MNNzFCgjl8B+O8po96 hxiZOBgPMUpwMCuJ8OYrMyQI8aYkVlalFuXHF5XmpBYfYpTmYFES5+X98ideSCA9sSQ1OzW1 ILUIJsvEwSnVwDRXYSnTvYJ9yXGue28uvfDl286LTL2vu4J+FRoYOuvscu0KVNll6vGJyznP Y93bQ3vUJUK3GH3+FcFQ98Tll+Ka71djz0rv+3tEsklg/eM1V6cnf/+2ZGmA1OWs2wbdV48o CK6SNN63pF/RrScoTupW3dbNqVN/szj/c7byqJ9Wl8FmcGrBmW2/bzz2mL8yOkik9sjz2U9P Oz6czv00qDxhXl341BO7vX4fb0wMSPX/usLuC0O9wbSZtT2CXnfv/PUOMTJ9URg5wSKKVydA 62nnP6ej4huOztbXUjRoOd1zcdvSRafFJyzb4r35t6dC4ac9ol8KZm67t+md4LzdfusVKxZm HI5eP8dJeWbgX6V1SizFGYmGWsxFxYkAqTP3E9UCAAA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.005959, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 15 Jan 2021 09:49:24 +0100 Oscar Salvador wrote: > I am having a hard time trying to grasp what are you trying to achieve here. > Could you elaborate some more? Ideally stating what is the problem you are > fixing here. > Sorry for confusion, example: there are four process A,B,C,D,which map the same file into there process space, which set there PF_MCE_KILL_EARLY flag to TRUE, if process A trigger one UE with MF_ACTION_REQUIRED set, in current code, only process A will be killed, B,C,D remain alive, but for the PF_MCE_KILL_EARLY we set, we want B,C,D also be killed. this is what I want to fix. > If it is not set by the caller of memory_failure, we still want to check the > task/threads' MCE policy to check whether PF_MCE_KILL_EARLY it was set with > prctl, right? > Yes, right! > That makes sense to me. > > So, back to your change, if force_early was set, but the main task does not > match, you still want to check whether any thread belonging to the main task > has the policy set? > Yes. -- Best Regards! Aili Yao