linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Aili Yao <yaoaili@kingsoft.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: <naoya.horiguchi@nec.com>, <linux-mm@kvack.org>,
	<yangfeng1@kingsoft.com>
Subject: Re: [PATCH] mm,hwpoison: non-current task should be checked early_kill for force_early
Date: Fri, 15 Jan 2021 17:26:22 +0800	[thread overview]
Message-ID: <20210115172622.699d68e5.yaoaili@kingsoft.com> (raw)
In-Reply-To: <20210115084920.GA4092@linux>

On Fri, 15 Jan 2021 09:49:24 +0100
Oscar Salvador <osalvador@suse.de> wrote:

> I am having a hard time trying to grasp what are you trying to achieve here.
> Could you elaborate some more? Ideally stating what is the problem you are
> fixing here.
> 
Sorry for confusion, example: there are four process A,B,C,D,which map the same file into
there process space, which set there PF_MCE_KILL_EARLY flag to TRUE, if process A trigger one
UE with  MF_ACTION_REQUIRED set, in current code, only process A will be killed, B,C,D remain
alive, but for the PF_MCE_KILL_EARLY we set, we want B,C,D also be killed.
this is what I want to fix.

> If it is not set by the caller of memory_failure, we still want to check the
> task/threads' MCE policy to check whether PF_MCE_KILL_EARLY it was set with
> prctl, right?
>
Yes, right! 

> That makes sense to me.
> 
> So, back to your change, if force_early was set, but the main task does not
> match, you still want to check whether any thread belonging to the main task
> has the policy set?
> 
Yes.

-- 
Best Regards!

Aili Yao


  reply	other threads:[~2021-01-15  9:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15  7:55 Aili Yao
2021-01-15  8:49 ` Oscar Salvador
2021-01-15  9:26   ` Aili Yao [this message]
2021-01-15  9:31     ` Aili Yao
2021-01-15  9:40       ` Oscar Salvador
2021-01-15  9:53         ` Aili Yao
2021-01-15 10:31     ` Oscar Salvador
2021-01-18  5:15     ` HORIGUCHI NAOYA(堀口 直也)
2021-01-18  5:57       ` Aili Yao
2021-01-18  6:50         ` HORIGUCHI NAOYA(堀口 直也)
2021-01-18  7:16           ` Aili Yao
2021-01-18  8:15           ` Aili Yao
2021-01-18  8:57             ` HORIGUCHI NAOYA(堀口 直也)
2021-01-18  9:09               ` Aili Yao
2021-01-19  5:25                 ` HORIGUCHI NAOYA(堀口 直也)
2021-01-19  6:04                   ` Aili Yao
2021-01-19  7:33                     ` HORIGUCHI NAOYA(堀口 直也)
2021-01-18  9:24               ` Oscar Salvador
2021-01-18  9:38                 ` Aili Yao
2021-01-18 10:09                   ` Oscar Salvador
2021-01-19  4:21               ` Aili Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210115172622.699d68e5.yaoaili@kingsoft.com \
    --to=yaoaili@kingsoft.com \
    --cc=linux-mm@kvack.org \
    --cc=naoya.horiguchi@nec.com \
    --cc=osalvador@suse.de \
    --cc=yangfeng1@kingsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox