From: Oscar Salvador <osalvador@suse.de>
To: Muchun Song <songmuchun@bytedance.com>
Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org,
n-horiguchi@ah.jp.nec.com, ak@linux.intel.com, mhocko@suse.cz,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v6 5/5] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active
Date: Fri, 15 Jan 2021 14:27:53 +0100 [thread overview]
Message-ID: <20210115132753.GC10102@linux> (raw)
In-Reply-To: <20210115124942.46403-6-songmuchun@bytedance.com>
On Fri, Jan 15, 2021 at 08:49:42PM +0800, Muchun Song wrote:
> The page_huge_active() can be called from scan_movable_pages() which
> do not hold a reference count to the HugeTLB page. So when we call
> page_huge_active() from scan_movable_pages(), the HugeTLB page can
> be freed parallel. Then we will trigger a BUG_ON which is in the
> page_huge_active() when CONFIG_DEBUG_VM is enabled. Just remove the
> VM_BUG_ON_PAGE.
>
> Fixes: 7e1f049efb86 ("mm: hugetlb: cleanup using paeg_huge_active()")
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE L3
prev parent reply other threads:[~2021-01-15 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 12:49 [PATCH v6 0/5] Fix some bugs about HugeTLB code Muchun Song
2021-01-15 12:49 ` [PATCH v6 1/5] mm: migrate: do not migrate HugeTLB page whose refcount is one Muchun Song
2021-01-15 12:49 ` [PATCH v6 2/5] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page Muchun Song
2021-01-15 12:49 ` [PATCH v6 3/5] mm: hugetlb: fix a race between freeing and dissolving the page Muchun Song
2021-01-15 13:22 ` Oscar Salvador
2021-01-18 9:13 ` Michal Hocko
2021-01-15 12:49 ` [PATCH v6 4/5] mm: hugetlb: fix a race between isolating and freeing page Muchun Song
2021-01-15 13:26 ` Oscar Salvador
2021-01-15 12:49 ` [PATCH v6 5/5] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Muchun Song
2021-01-15 13:27 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115132753.GC10102@linux \
--to=osalvador@suse.de \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mhocko@suse.cz \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=songmuchun@bytedance.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox