From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2802AC433E0 for ; Fri, 15 Jan 2021 12:51:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D777C221F7 for ; Fri, 15 Jan 2021 12:51:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D777C221F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7ECD46B013B; Fri, 15 Jan 2021 07:51:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 779CB8D0162; Fri, 15 Jan 2021 07:51:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63D176B013F; Fri, 15 Jan 2021 07:51:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 505696B013B for ; Fri, 15 Jan 2021 07:51:35 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 157BA1E03 for ; Fri, 15 Jan 2021 12:51:35 +0000 (UTC) X-FDA: 77707995750.20.shelf43_4f029f62752f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id EDC1F180C060F for ; Fri, 15 Jan 2021 12:51:34 +0000 (UTC) X-HE-Tag: shelf43_4f029f62752f X-Filterd-Recvd-Size: 4284 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 12:51:34 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id y12so5012603pji.1 for ; Fri, 15 Jan 2021 04:51:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+oq/pZri5P5cicdjvF/NV+dEw2QpXHjaPU5Z1WvWQMU=; b=QiizyrXVk9Caq+Dq/aCAmt2FvbOtK/UvO/5SMwa1kR6eOjgvONO+R+p4aPkgV5Chcn XwSrin4YYDiDHBwfPVC0heYZFWV11c1+egr7bUEKOLvd1AL/RU30tDvj59CvxDhwbm6X WIB+TJYvCG5p+282nlra7vHDx26nXfgS6Tuh4w/AAnl2tBE1nXAwqP763dvTzkk+EX/R nWCfyNU+vcdrWmaH8wZNerSs2GQsxiG7AG2MDWoZ4yZFr1ShDrN2ciAqTyqhw9bhEvS6 ZdZ8pXTfu4/CWCGDAWVoWN0Xq4EIx3p4N3h96/G4MiCk9ZhhX6Jk9058TPQr9uChUwaw 2nKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+oq/pZri5P5cicdjvF/NV+dEw2QpXHjaPU5Z1WvWQMU=; b=KPalch6WNQgjU130MwVugKSztm+Jif7g4CYbc3albTcLtS2/xR9Jc8ZzwhcPPKtzRg S/fl9Bc4tVwRxw8EHa2pJskE7fnHgPTymuXVZ4WjpuEIuVp8IlqxbfoqdhBSNrUpbwNt G92lt2LE+02TYPIdoih7siFvKLSrSmwLTK9XEycZ5sdbyLSOidoI6lvwiA4p6bKHSln0 4LwqOR3yKAfkxKlVviRjPJOpIhH7PL+mmt2eP0aoHUK3f71+GB95ir+whjF40WuEjxE2 0P7QSgxyzJOYIJBKPa6JG2HhXN7D1z2bFlvIw0nQ+l+3V2iRT542+TWyWRdupbAVYzr4 6uWg== X-Gm-Message-State: AOAM533GT2lDCBiGUr84VIg+lh+SIEw5EEZrWEXU4hLvYjkAk6kaZe9U h8/g5uK88cJO6P4gWhUrqG7SxA== X-Google-Smtp-Source: ABdhPJxod0INgeZhKzOkKfmLTxzpi/GXYx3l8jx7/eCcpACoBmjkXMvDlVhC3XFVyekI1Ig7/077gw== X-Received: by 2002:a17:90a:b296:: with SMTP id c22mr10718986pjr.142.1610715093829; Fri, 15 Jan 2021 04:51:33 -0800 (PST) Received: from localhost.localdomain ([139.177.225.247]) by smtp.gmail.com with ESMTPSA id c5sm8193600pjo.4.2021.01.15.04.51.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jan 2021 04:51:33 -0800 (PST) From: Muchun Song To: mike.kravetz@oracle.com, akpm@linux-foundation.org Cc: n-horiguchi@ah.jp.nec.com, ak@linux.intel.com, mhocko@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Michal Hocko , stable@vger.kernel.org Subject: [PATCH v6 5/5] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Date: Fri, 15 Jan 2021 20:49:42 +0800 Message-Id: <20210115124942.46403-6-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20210115124942.46403-1-songmuchun@bytedance.com> References: <20210115124942.46403-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The page_huge_active() can be called from scan_movable_pages() which do not hold a reference count to the HugeTLB page. So when we call page_huge_active() from scan_movable_pages(), the HugeTLB page can be freed parallel. Then we will trigger a BUG_ON which is in the page_huge_active() when CONFIG_DEBUG_VM is enabled. Just remove the VM_BUG_ON_PAGE. Fixes: 7e1f049efb86 ("mm: hugetlb: cleanup using paeg_huge_active()") Signed-off-by: Muchun Song Reviewed-by: Mike Kravetz Acked-by: Michal Hocko Cc: stable@vger.kernel.org --- mm/hugetlb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index f2cef3cf1f85..2d671f3743f5 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -1360,8 +1360,7 @@ struct hstate *size_to_hstate(unsigned long size) */ bool page_huge_active(struct page *page) { - VM_BUG_ON_PAGE(!PageHuge(page), page); - return PageHead(page) && PagePrivate(&page[1]); + return PageHeadHuge(page) && PagePrivate(&page[1]); } =20 /* never called for tail page */ --=20 2.11.0