From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F84C433E0 for ; Fri, 15 Jan 2021 10:31:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 03E74235F9 for ; Fri, 15 Jan 2021 10:31:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03E74235F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 65BF28D0158; Fri, 15 Jan 2021 05:31:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60BC68D0023; Fri, 15 Jan 2021 05:31:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 521688D0158; Fri, 15 Jan 2021 05:31:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 3938E8D0023 for ; Fri, 15 Jan 2021 05:31:42 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id EFBE2181AF5C2 for ; Fri, 15 Jan 2021 10:31:41 +0000 (UTC) X-FDA: 77707643202.05.death85_3f092802752e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id D69DD1801D53D for ; Fri, 15 Jan 2021 10:31:41 +0000 (UTC) X-HE-Tag: death85_3f092802752e X-Filterd-Recvd-Size: 2092 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 10:31:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 43B63AE22; Fri, 15 Jan 2021 10:31:40 +0000 (UTC) Date: Fri, 15 Jan 2021 11:31:37 +0100 From: Oscar Salvador To: Aili Yao Cc: naoya.horiguchi@nec.com, linux-mm@kvack.org, yangfeng1@kingsoft.com Subject: Re: [PATCH] mm,hwpoison: non-current task should be checked early_kill for force_early Message-ID: <20210115103137.GB5213@linux> References: <20210115155506.2d59fe83.yaoaili@kingsoft.com> <20210115084920.GA4092@linux> <20210115172622.699d68e5.yaoaili@kingsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210115172622.699d68e5.yaoaili@kingsoft.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 15, 2021 at 05:26:22PM +0800, Aili Yao wrote: > On Fri, 15 Jan 2021 09:49:24 +0100 > Oscar Salvador wrote: > > > I am having a hard time trying to grasp what are you trying to achieve here. > > Could you elaborate some more? Ideally stating what is the problem you are > > fixing here. > > > Sorry for confusion, example: there are four process A,B,C,D,which map the same file into > there process space, which set there PF_MCE_KILL_EARLY flag to TRUE, if process A trigger one > UE with MF_ACTION_REQUIRED set, in current code, only process A will be killed, B,C,D remain > alive, but for the PF_MCE_KILL_EARLY we set, we want B,C,D also be killed. > this is what I want to fix. This should really be part of the changelog. (what is it fixing? how? why?) All this information should be there. And the title should be renamed as well as it is bit confusing as is. "Do not bail out in task_early_kill when force_early is set" or something along those lines. -- Oscar Salvador SUSE L3