From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F61C433E0 for ; Fri, 15 Jan 2021 09:40:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6402B2339D for ; Fri, 15 Jan 2021 09:40:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6402B2339D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C4C3C8D014A; Fri, 15 Jan 2021 04:40:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BFCAD8D0023; Fri, 15 Jan 2021 04:40:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B124E8D014A; Fri, 15 Jan 2021 04:40:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 981768D0023 for ; Fri, 15 Jan 2021 04:40:42 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5AAE4EFBC for ; Fri, 15 Jan 2021 09:40:42 +0000 (UTC) X-FDA: 77707514724.19.burst97_0211aa02752e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 3D7D91ACC29 for ; Fri, 15 Jan 2021 09:40:42 +0000 (UTC) X-HE-Tag: burst97_0211aa02752e X-Filterd-Recvd-Size: 1663 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 09:40:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 73040B732; Fri, 15 Jan 2021 09:40:40 +0000 (UTC) Date: Fri, 15 Jan 2021 10:40:37 +0100 From: Oscar Salvador To: Aili Yao Cc: naoya.horiguchi@nec.com, linux-mm@kvack.org, yangfeng1@kingsoft.com Subject: Re: [PATCH] mm,hwpoison: non-current task should be checked early_kill for force_early Message-ID: <20210115094037.GD4092@linux> References: <20210115155506.2d59fe83.yaoaili@kingsoft.com> <20210115084920.GA4092@linux> <20210115172622.699d68e5.yaoaili@kingsoft.com> <20210115173125.078d8c13.yaoaili@kingsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210115173125.078d8c13.yaoaili@kingsoft.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 15, 2021 at 05:31:25PM +0800, Aili Yao wrote: > On Fri, 15 Jan 2021 17:26:22 +0800 > Aili Yao wrote: > > > > So, back to your change, if force_early was set, but the main task does not > > > match, you still want to check whether any thread belonging to the main task > > > has the policy set? > > > > > Yes. > > > Sorry, the code only loop processes, not thread. The loop in task_early_kill goes through processes, while the one in find_early_kill_thread goes through threads, right? -- Oscar Salvador SUSE L3