From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C728C433E0 for ; Thu, 14 Jan 2021 14:52:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1EE5C23A6C for ; Thu, 14 Jan 2021 14:52:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EE5C23A6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 18E548D00E8; Thu, 14 Jan 2021 09:52:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13F238D008E; Thu, 14 Jan 2021 09:52:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 006108D00E8; Thu, 14 Jan 2021 09:52:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id DAFB68D008E for ; Thu, 14 Jan 2021 09:52:36 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 92068365C for ; Thu, 14 Jan 2021 14:52:36 +0000 (UTC) X-FDA: 77704671912.06.girls25_431620e27527 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 717D31004F722 for ; Thu, 14 Jan 2021 14:52:36 +0000 (UTC) X-HE-Tag: girls25_431620e27527 X-Filterd-Recvd-Size: 2576 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 14:52:35 +0000 (UTC) Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2315A23A5E; Thu, 14 Jan 2021 14:52:34 +0000 (UTC) Date: Thu, 14 Jan 2021 09:52:32 -0500 From: Steven Rostedt To: Alexander Potapenko Cc: Andrew Morton , LKML , Marco Elver , Andrey Konovalov , Dmitry Vyukov , Ingo Molnar , Petr Mladek , Sergey Senozhatsky , Linux Memory Management List Subject: Re: [PATCH 1/4] tracing: add error_report trace points Message-ID: <20210114095232.7ba3f9a8@gandalf.local.home> In-Reply-To: References: <20210113091657.1456216-1-glider@google.com> <20210113091657.1456216-2-glider@google.com> <20210113161044.43bc1c1a@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 14 Jan 2021 08:49:57 +0100 Alexander Potapenko wrote: > We'll need to explicitly list the enum values once again in > __print_symbolic(), right? E.g.: > > enum debugging_tool { > TOOL_KFENCE, > TOOL_KASAN, > ... > } > > TP_printk(__print_symbolic(__entry->error_detector, TOOL_KFENCE, > TOOL_KASAN, ...), Usually what is done is to make this into a macro: #define REPORT_TOOL_LIST \ EM(KFENCE, kfence) \ EMe(KASAN, kasan) #undef EM #undef EMe #define EM(a,b) TRACE_DEFINE_ENUM(a) #define EMe(a,b) TRACE_DEFINE_ENUM(a) REPORT_TOOL_LIST #undef EM #undef EMe #define EM(a, b) { a, b }, #define EMe(a, b) { a, b } #define show_report_tool_list(val) \ __print_symbolic(val, REPORT_TOOL_LIST) [..] TP_printk("[%s] %lx", show_report_tool_list(__entry->error_detector), __entry->id) This is done in several other trace event files. For example, see include/trace/events/sock.h -- Steve