From: Steven Rostedt <rostedt@goodmis.org>
To: Alexander Potapenko <glider@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Marco Elver <elver@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Ingo Molnar <mingo@redhat.com>, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH 1/4] tracing: add error_report trace points
Date: Thu, 14 Jan 2021 09:52:32 -0500 [thread overview]
Message-ID: <20210114095232.7ba3f9a8@gandalf.local.home> (raw)
In-Reply-To: <CAG_fn=XSkOChCwBp=Vg6jWhZ8K44seCo=0Zu38iUpAj6eCUxjQ@mail.gmail.com>
On Thu, 14 Jan 2021 08:49:57 +0100
Alexander Potapenko <glider@google.com> wrote:
> We'll need to explicitly list the enum values once again in
> __print_symbolic(), right? E.g.:
>
> enum debugging_tool {
> TOOL_KFENCE,
> TOOL_KASAN,
> ...
> }
>
> TP_printk(__print_symbolic(__entry->error_detector, TOOL_KFENCE,
> TOOL_KASAN, ...),
Usually what is done is to make this into a macro:
#define REPORT_TOOL_LIST \
EM(KFENCE, kfence) \
EMe(KASAN, kasan)
#undef EM
#undef EMe
#define EM(a,b) TRACE_DEFINE_ENUM(a)
#define EMe(a,b) TRACE_DEFINE_ENUM(a)
REPORT_TOOL_LIST
#undef EM
#undef EMe
#define EM(a, b) { a, b },
#define EMe(a, b) { a, b }
#define show_report_tool_list(val) \
__print_symbolic(val, REPORT_TOOL_LIST)
[..]
TP_printk("[%s] %lx", show_report_tool_list(__entry->error_detector),
__entry->id)
This is done in several other trace event files. For example, see
include/trace/events/sock.h
-- Steve
next prev parent reply other threads:[~2021-01-14 14:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210113091657.1456216-1-glider@google.com>
2021-01-13 9:16 ` Alexander Potapenko
2021-01-13 21:10 ` Steven Rostedt
2021-01-14 7:49 ` Alexander Potapenko
2021-01-14 8:59 ` Marco Elver
2021-01-14 14:52 ` Steven Rostedt [this message]
2021-01-15 12:53 ` Alexander Potapenko
2021-01-15 16:17 ` Steven Rostedt
2021-01-13 9:16 ` [PATCH 2/4] lib: add error_report_notify to collect debugging tools' reports Alexander Potapenko
2021-01-14 0:06 ` Andrew Morton
2021-01-14 9:51 ` Alexander Potapenko
2021-01-15 10:18 ` Alexander Potapenko
2021-01-13 9:16 ` [PATCH 3/4] kfence: use error_report_start and error_report_end tracepoints Alexander Potapenko
2021-01-13 9:16 ` [PATCH 4/4] kasan: " Alexander Potapenko
[not found] <20210113091017.1444780-1-glider@google.com>
2021-01-13 9:10 ` [PATCH 1/4] tracing: add error_report trace points Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114095232.7ba3f9a8@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox