Re: [PATCH] fs/proc: Expose RSEQ configuration

Re: [PATCH] fs/proc: Expose RSEQ configuration

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3037 bytes --]

Hi Piotr,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on userns/for-next]
[also build test WARNING on linus/master hnaz-linux-mm/master v5.11-rc3 next-20210113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Piotr-Figiel/fs-proc-Expose-RSEQ-configuration/20210114-014431
base:   https://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-next
config: i386-randconfig-s002-20210113 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-208-g46a52ca4-dirty
        # https://github.com/0day-ci/linux/commit/ac6c42405fbb35bb266d602e4d9a303e68fadc21
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Piotr-Figiel/fs-proc-Expose-RSEQ-configuration/20210114-014431
        git checkout ac6c42405fbb35bb266d602e4d9a303e68fadc21
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
   fs/proc/base.c:674:41: sparse: sparse: cast removes address space '__user' of expression
   fs/proc/base.c:2248:25: sparse: sparse: cast to restricted fmode_t
   fs/proc/base.c:2305:42: sparse: sparse: cast from restricted fmode_t
   fs/proc/base.c:2402:48: sparse: sparse: cast from restricted fmode_t
   fs/proc/base.c: note: in included file (through include/linux/rcuwait.h, include/linux/percpu-rwsem.h, include/linux/fs.h, ...):
   include/linux/sched/signal.h:708:37: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct spinlock [usertype] *lock @@     got struct spinlock [noderef] __rcu * @@
   include/linux/sched/signal.h:708:37: sparse:     expected struct spinlock [usertype] *lock
   include/linux/sched/signal.h:708:37: sparse:     got struct spinlock [noderef] __rcu *
>> fs/proc/base.c:674:50: sparse: sparse: non size-preserving pointer to integer cast
   fs/proc/base.c:1117:36: sparse: sparse: context imbalance in '__set_oom_adj' - unexpected unlock

vim +674 fs/proc/base.c

   665	
   666	#ifdef CONFIG_RSEQ
   667	static int proc_pid_rseq(struct seq_file *m, struct pid_namespace *ns,
   668					struct pid *pid, struct task_struct *task)
   669	{
   670		int res = lock_trace(task);
   671	
   672		if (res)
   673			return res;
 > 674		seq_printf(m, "0x%llx 0x%x\n", (uint64_t)task->rseq, task->rseq_sig);
   675		unlock_trace(task);
   676		return 0;
   677	}
   678	#endif /* CONFIG_RSEQ */
   679	#endif /* CONFIG_HAVE_ARCH_TRACEHOOK */
   680	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29819 bytes --]

Re: [PATCH] fs/proc: Expose RSEQ configuration

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2378 bytes --]

Hi Piotr,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on userns/for-next]
[also build test WARNING on linus/master hnaz-linux-mm/master v5.11-rc3 next-20210113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Piotr-Figiel/fs-proc-Expose-RSEQ-configuration/20210114-014431
base:   https://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-next
config: mips-randconfig-r011-20210113 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ac6c42405fbb35bb266d602e4d9a303e68fadc21
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Piotr-Figiel/fs-proc-Expose-RSEQ-configuration/20210114-014431
        git checkout ac6c42405fbb35bb266d602e4d9a303e68fadc21
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/proc/base.c: In function 'proc_pid_rseq':
>> fs/proc/base.c:674:33: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     674 |  seq_printf(m, "0x%llx 0x%x\n", (uint64_t)task->rseq, task->rseq_sig);
         |                                 ^


vim +674 fs/proc/base.c

   665	
   666	#ifdef CONFIG_RSEQ
   667	static int proc_pid_rseq(struct seq_file *m, struct pid_namespace *ns,
   668					struct pid *pid, struct task_struct *task)
   669	{
   670		int res = lock_trace(task);
   671	
   672		if (res)
   673			return res;
 > 674		seq_printf(m, "0x%llx 0x%x\n", (uint64_t)task->rseq, task->rseq_sig);
   675		unlock_trace(task);
   676		return 0;
   677	}
   678	#endif /* CONFIG_RSEQ */
   679	#endif /* CONFIG_HAVE_ARCH_TRACEHOOK */
   680	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30531 bytes --]