From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC24C433DB for ; Wed, 13 Jan 2021 23:40:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A4367233ED for ; Wed, 13 Jan 2021 23:40:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4367233ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22CE48D00A0; Wed, 13 Jan 2021 18:40:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B5B08D008E; Wed, 13 Jan 2021 18:40:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07C778D00A0; Wed, 13 Jan 2021 18:40:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id E19DB8D008E for ; Wed, 13 Jan 2021 18:40:47 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A5D95181AEF3C for ; Wed, 13 Jan 2021 23:40:47 +0000 (UTC) X-FDA: 77702374134.06.jeans29_5a1211727522 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 86B291004DB5D for ; Wed, 13 Jan 2021 23:40:47 +0000 (UTC) X-HE-Tag: jeans29_5a1211727522 X-Filterd-Recvd-Size: 4525 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Jan 2021 23:40:46 +0000 (UTC) Received: by mail-qk1-f170.google.com with SMTP id h4so4738002qkk.4 for ; Wed, 13 Jan 2021 15:40:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eWOJblEmC2Qz30+n062pHjcbFMkB3dcTw0EMbDyU9wY=; b=g7Myi4v2XKsgahixTj7abmQLC+QpYM/NxeNwy/T8Ur/tenbnt6MQs8Sid+jONGzRNm AI4vOuYLwnMplCgfxZdoOUxfSCGGPzTI0rBZZeDZLugknRZWcI1fBRE7t0Y26Bq1lhDn D2v+ZmEhMwZe5THa8LEBL/6+hwEc80GktfKyYBm9B2dFlfu8sXyyEgUNb6rVw4bNvV9F rjHEQn6/W+mNOc2uFt1hqrzZBmxkdb7iifCZ1CZKz5lTnPfzjqD/9qPOCswmP7TaTbe9 SrkZUewTrJw/en30riV5ldgu6rAHbskg6Z5JXS+Yk1vFxG1U42IhrdUMlq8PkrzzN+3a wzpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eWOJblEmC2Qz30+n062pHjcbFMkB3dcTw0EMbDyU9wY=; b=ap43Dh93p9026cqOq4oyHEyNO+pWkmb9JQOKHuthZi+ByFp0L7azWvPDP+Nwvj7vhq J5mP3xgoqxXLn68VcL7XPZ4D2bd0WeLiy1dty9eAoJRBzBIQO5lqFhl8a3Z3dsd18lU5 hGGhZJH1VO0qA5YUzGjotytZIlqTWg04k96pAlDErDYqsAe1kWtaqUnnte1lBiANv8zb 1/y1pGd7+78fC7GhZG0B3n5gJRUiNCcoa6KPn8Ha2c3uCVu77Q7ODzRjYo3OPSaK7wnB Nz0djXfUBPZZOpKWHoAeKUAS/du5AXr6sLUI0ELRakNW7Erb2WidtgNZAjD+GjiYqVWx 1K8Q== X-Gm-Message-State: AOAM530qIlmx2EifEohi41yLaKO6/nb7MhPEQzxTwJa42OwD749UmPAW sKoH+2WCvZJk7FkuZta8HouDLQ== X-Google-Smtp-Source: ABdhPJy0csB1QSw/8eYTomPSY9yssASx5+uIbw+aIaQIxvw9keP0iEvsHPmZYqbPjcaIzfDKssrusA== X-Received: by 2002:a05:620a:673:: with SMTP id a19mr4538618qkh.353.1610581246377; Wed, 13 Jan 2021 15:40:46 -0800 (PST) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id y13sm2147803qkb.17.2021.01.13.15.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 15:40:45 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kzpkq-000htB-US; Wed, 13 Jan 2021 19:40:44 -0400 Date: Wed, 13 Jan 2021 19:40:44 -0400 From: Jason Gunthorpe To: Pavel Tatashin Cc: LKML , linux-mm , Andrew Morton , Vlastimil Babka , Michal Hocko , David Hildenbrand , Oscar Salvador , Dan Williams , Sasha Levin , Tyler Hicks , Joonsoo Kim , mike.kravetz@oracle.com, Steven Rostedt , Ingo Molnar , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes , John Hubbard , Linux Doc Mailing List , Ira Weiny , linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 08/10] mm/gup: limit number of gup migration failures, honor failures Message-ID: <20210113234044.GF4605@ziepe.ca> References: <20201217185243.3288048-1-pasha.tatashin@soleen.com> <20201217185243.3288048-9-pasha.tatashin@soleen.com> <20201217205048.GL5487@ziepe.ca> <20201218141927.GM5487@ziepe.ca> <20210113195528.GD4605@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 13, 2021 at 03:05:41PM -0500, Pavel Tatashin wrote: > Makes sense, I will remove maximum retries for isolation, and retry > indefinitely, the same as it is done during memory hot-remove. So, we > will fail only when migration fails. It would be good to make this also as a stand alone pre-fix as well.. Thanks, Jason