From: "Michal Koutný" <mkoutny@suse.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Roman Gushchin <guro@fb.com>,
Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] mm: memcontrol: prevent starvation when writing memory.high
Date: Wed, 13 Jan 2021 18:25:38 +0100 [thread overview]
Message-ID: <20210113172522.GA14726@blackbody.suse.cz> (raw)
In-Reply-To: <20210112163011.127833-1-hannes@cmpxchg.org>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Tue, Jan 12, 2021 at 11:30:11AM -0500, Johannes Weiner <hannes@cmpxchg.org> wrote:
> - reclaimed = try_to_free_mem_cgroup_pages(memcg, nr_pages - high,
> - GFP_KERNEL, true);
> + try_to_free_mem_cgroup_pages(memcg, nr_pages - high,
> + GFP_KERNEL, true);
Although I was also initially confused by throwing 'reclaimed' info
away, the patch makes sense to me given the reasoning.
It is
Reviewed-by: Michal Koutný <mkoutny@suse.com>
As for the discussed unsuccessful retries, I'd keep it a separate change.
Regards,
Michal
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-13 17:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 16:30 Johannes Weiner
2021-01-12 17:03 ` Roman Gushchin
2021-01-12 19:45 ` Johannes Weiner
2021-01-12 20:12 ` Roman Gushchin
2021-01-12 21:11 ` Johannes Weiner
2021-01-12 21:45 ` Roman Gushchin
2021-01-15 15:34 ` Johannes Weiner
2021-01-12 18:59 ` Shakeel Butt
2021-01-12 19:53 ` Johannes Weiner
2021-01-12 20:28 ` Shakeel Butt
2021-01-13 14:46 ` Michal Hocko
2021-01-15 16:20 ` Johannes Weiner
2021-01-15 17:03 ` Roman Gushchin
2021-01-15 20:55 ` Johannes Weiner
2021-01-15 21:27 ` Roman Gushchin
2021-01-19 16:47 ` Johannes Weiner
2021-01-18 13:12 ` Michal Hocko
2021-01-13 17:25 ` Michal Koutný [this message]
2021-01-13 18:06 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113172522.GA14726@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox