From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 799B1C433E6 for ; Wed, 13 Jan 2021 21:10:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B132723107 for ; Wed, 13 Jan 2021 21:10:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B132723107 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4B3AE8D0096; Wed, 13 Jan 2021 16:10:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 463288D008E; Wed, 13 Jan 2021 16:10:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 379698D0096; Wed, 13 Jan 2021 16:10:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 21DEC8D008E for ; Wed, 13 Jan 2021 16:10:49 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BB1DF362E for ; Wed, 13 Jan 2021 21:10:48 +0000 (UTC) X-FDA: 77701996176.15.twig91_070be8c27521 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 97E791814B0C9 for ; Wed, 13 Jan 2021 21:10:48 +0000 (UTC) X-HE-Tag: twig91_070be8c27521 X-Filterd-Recvd-Size: 2132 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Jan 2021 21:10:48 +0000 (UTC) Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3525721D95; Wed, 13 Jan 2021 21:10:46 +0000 (UTC) Date: Wed, 13 Jan 2021 16:10:44 -0500 From: Steven Rostedt To: Alexander Potapenko Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Marco Elver , Andrey Konovalov , Dmitry Vyukov , Ingo Molnar , Petr Mladek , Sergey Senozhatsky , linux-mm@kvack.org Subject: Re: [PATCH 1/4] tracing: add error_report trace points Message-ID: <20210113161044.43bc1c1a@gandalf.local.home> In-Reply-To: <20210113091657.1456216-2-glider@google.com> References: <20210113091657.1456216-1-glider@google.com> <20210113091657.1456216-2-glider@google.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 13 Jan 2021 10:16:54 +0100 Alexander Potapenko wrote: > +DECLARE_EVENT_CLASS(error_report_template, > + TP_PROTO(const char *error_detector, unsigned long id), Instead of having a random string, as this should be used by a small finite set of subsystems, why not make the above into an enum? > + TP_ARGS(error_detector, id), > + TP_STRUCT__entry(__field(const char *, error_detector) > + __field(unsigned long, id)), > + TP_fast_assign(__entry->error_detector = error_detector; > + __entry->id = id;), > + TP_printk("[%s] %lx", __entry->error_detector, Then the [%s] portion of this could also be just a __print_symbolic(). -- Steve > + __entry->id)); > + > +/**