From: Oscar Salvador <osalvador@suse.de>
To: Muchun Song <songmuchun@bytedance.com>
Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org,
n-horiguchi@ah.jp.nec.com, ak@linux.intel.com, mhocko@suse.cz,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v4 2/6] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page
Date: Wed, 13 Jan 2021 12:00:51 +0100 [thread overview]
Message-ID: <20210113110051.GB26599@linux> (raw)
In-Reply-To: <20210113052209.75531-3-songmuchun@bytedance.com>
On Wed, Jan 13, 2021 at 01:22:05PM +0800, Muchun Song wrote:
> If a new hugetlb page is allocated during fallocate it will not be
> marked as active (set_page_huge_active) which will result in a later
> isolate_huge_page failure when the page migration code would like to
> move that page. Such a failure would be unexpected and wrong.
>
> Only export set_page_huge_active, just leave clear_page_huge_active
> as static. Because there are no external users.
>
> Fixes: 70c3547e36f5 (hugetlbfs: add hugetlbfs_fallocate())
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2021-01-13 11:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 5:22 [PATCH v4 0/6] Fix some bugs about HugeTLB code Muchun Song
2021-01-13 5:22 ` [PATCH v4 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one Muchun Song
2021-01-13 10:30 ` David Hildenbrand
2021-01-13 10:57 ` Oscar Salvador
2021-01-13 11:03 ` [External] " Muchun Song
2021-01-13 5:22 ` [PATCH v4 2/6] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page Muchun Song
2021-01-13 11:00 ` Oscar Salvador [this message]
2021-01-13 5:22 ` [PATCH v4 3/6] mm: hugetlb: fix a race between freeing and dissolving the page Muchun Song
2021-01-13 9:31 ` Michal Hocko
2021-01-13 5:22 ` [PATCH v4 4/6] mm: hugetlb: retry dissolve page when hitting race Muchun Song
2021-01-13 9:33 ` Michal Hocko
2021-01-13 10:14 ` [External] " Muchun Song
2021-01-13 10:38 ` Michal Hocko
2021-01-13 11:11 ` Muchun Song
2021-01-13 11:14 ` Oscar Salvador
2021-01-13 11:20 ` Muchun Song
2021-01-13 12:03 ` Michal Hocko
2021-01-13 11:22 ` Michal Hocko
2021-01-13 12:15 ` Muchun Song
2021-01-13 5:22 ` [PATCH v4 5/6] mm: hugetlb: fix a race between isolating and freeing page Muchun Song
2021-01-13 5:22 ` [PATCH v4 6/6] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113110051.GB26599@linux \
--to=osalvador@suse.de \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mhocko@suse.cz \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=songmuchun@bytedance.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox