From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C121EC433E0 for ; Wed, 13 Jan 2021 01:31:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 47BD02312F for ; Wed, 13 Jan 2021 01:31:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47BD02312F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 787378D0002; Tue, 12 Jan 2021 20:31:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 737C96B0106; Tue, 12 Jan 2021 20:31:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 627F88D0002; Tue, 12 Jan 2021 20:31:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 4BE056B0104 for ; Tue, 12 Jan 2021 20:31:34 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 176C8824556B for ; Wed, 13 Jan 2021 01:31:34 +0000 (UTC) X-FDA: 77699024508.30.turn05_04162bd2751a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id E9C13180B3AA7 for ; Wed, 13 Jan 2021 01:31:33 +0000 (UTC) X-HE-Tag: turn05_04162bd2751a X-Filterd-Recvd-Size: 5739 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Jan 2021 01:31:33 +0000 (UTC) Received: by mail-qk1-f169.google.com with SMTP id f26so306423qka.0 for ; Tue, 12 Jan 2021 17:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fq9Plgov79IhfrzoAKOz8rulKlgb6ke/+f1nKnQxxW0=; b=Z5V6pwugh8tpNgcEBRyoj+Y6Z5AJg6B0zPtKXl64DjRA3KzMducbX7nTwFGIAMeinn OJ5UxJDRPPgeiEUD59NOxYKDcmjU681HofoD+pZcTdXdjrOBGK2zYONOtnVArf4hSNbp bDMD5G67TN8/sI+6XN8v6ysAMejiveE29xmXw6Xa46Yl5Tx0avjB9U0g0iwKzH6IoJnr 2rDY2OpNlgN8LdWGEg8JHBWD9ge1MPbVDdh7vs7kF9HwTmomO1vt0YzodX8tAh/cM0+Z ajsVUggdrrI7vUnD2vPsd8rt0PU6ko1ygWfTPs+GUMDk0eoq3v4MpHiy1+2KGCqQ21w8 cSzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fq9Plgov79IhfrzoAKOz8rulKlgb6ke/+f1nKnQxxW0=; b=WANjkYSWu0WziSNIPllYOAMkd0sTIFxn3hLJDHk2B7aHcy4xsdBl6Qwirn+tuKs7k0 SoUcoVxFl845NJrQ2JFBALJiSLOH4lz/osrknI6mFlrO6icRP4r+kcxVJ+DzIJR2wY1A UVpSrHDPYQsqxZAEqWQC3pZgHt70MVOlcH0GXoLIs57K3PPL0eg7ALRvyEMykFFz9ZiS hblvQBZyJnOoK01IOBHqa0AyWeELRmvp3Jf0Wk9WUGoLBSeEwUkw0uW8e948Ecgxbq8w N6FrQCi5flOszuhQGG82HZzpCPNeiUQ2i3RwikfyYAtDmvkLKfF9qkCdwjSDHwPUZZmt r23Q== X-Gm-Message-State: AOAM530u+U0VEuTP5PGtFqt3qmI6nquOoRjPpn/aEMQHVnKiqp5X7slv zXW0vudKmSGNg6o2mVbzkE8= X-Google-Smtp-Source: ABdhPJxLwlEhkHUnqWeAiKaHu6jH5hxYS83PqqIV5mX9qhLsuLjCu2BU4yHY7ertRC4ihze41+Gy6A== X-Received: by 2002:a37:9b8a:: with SMTP id d132mr2556778qke.81.1610501492549; Tue, 12 Jan 2021 17:31:32 -0800 (PST) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id p15sm248369qtu.26.2021.01.12.17.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 17:31:31 -0800 (PST) Date: Tue, 12 Jan 2021 18:31:30 -0700 From: Nathan Chancellor To: kernel test robot Cc: Kees Cook , Andrew Morton , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Nick Desaulniers , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ubsan: Implement __ubsan_handle_alignment_assumption Message-ID: <20210113013130.GA3446359@ubuntu-m3-large-x86> References: <20210112205542.1375847-1-natechancellor@gmail.com> <202101130859.JSORPQUn-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202101130859.JSORPQUn-lkp@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 13, 2021 at 08:39:52AM +0800, kernel test robot wrote: > Hi Nathan, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on 7c53f6b671f4aba70ff15e1b05148b10d58c2837] > > url: https://github.com/0day-ci/linux/commits/Nathan-Chancellor/ubsan-Implement-__ubsan_handle_alignment_assumption/20210113-055714 > base: 7c53f6b671f4aba70ff15e1b05148b10d58c2837 > config: arm64-randconfig-r031-20210112 (attached as .config) > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 32bcfcda4e28375e5a85268d2acfabcfcc011abf) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm64 cross compiling tool for clang build > # apt-get install binutils-aarch64-linux-gnu > # https://github.com/0day-ci/linux/commit/775adad26a60878926c0ee6cd460a1375bbe51e6 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Nathan-Chancellor/ubsan-Implement-__ubsan_handle_alignment_assumption/20210113-055714 > git checkout 775adad26a60878926c0ee6cd460a1375bbe51e6 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > lib/ubsan.c:192:6: warning: no previous prototype for function '__ubsan_handle_add_overflow' [-Wmissing-prototypes] > void __ubsan_handle_add_overflow(void *data, > ^ > lib/ubsan.c:192:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > void __ubsan_handle_add_overflow(void *data, > ^ > static > lib/ubsan.c:200:6: warning: no previous prototype for function '__ubsan_handle_sub_overflow' [-Wmissing-prototypes] > void __ubsan_handle_sub_overflow(void *data, > ^ > lib/ubsan.c:200:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > void __ubsan_handle_sub_overflow(void *data, > ^ Given that these are compiler inserted functions, there is not much of a point to having prototypes to them. If people feel shutting these warnings up is worthwhile, we can just add the prototypes right above the function definition in a follow up patch. Cheers, Nathan