From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D8B6C433E0 for ; Tue, 12 Jan 2021 23:49:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1EB8323132 for ; Tue, 12 Jan 2021 23:49:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EB8323132 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A19AC6B011C; Tue, 12 Jan 2021 18:49:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C83E6B011D; Tue, 12 Jan 2021 18:49:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DD3C6B011E; Tue, 12 Jan 2021 18:49:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 6EF7F6B011C for ; Tue, 12 Jan 2021 18:49:20 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 405DF362D for ; Tue, 12 Jan 2021 23:49:20 +0000 (UTC) X-FDA: 77698766880.14.veil95_491567127519 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 1F47218229818 for ; Tue, 12 Jan 2021 23:49:20 +0000 (UTC) X-HE-Tag: veil95_491567127519 X-Filterd-Recvd-Size: 2309 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 23:49:19 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 7EE3D23136; Tue, 12 Jan 2021 23:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1610495358; bh=Fyfc3St6XcETCyfxluudtDudj6bhhgxSuzF95j2USdc=; h=Date:From:To:Subject:In-Reply-To:From; b=aokZhffsiHHbXlNGDfx4+YHl54EUfd5rsVedet7FuCJ5HSJ8fpcLzkDxa2ohR+iaE TWkG7gEcBaoFNOtJeSGNKgK2s4qlmXhT8kViDNC4RIyRPM9aEJ3wV3dyHF/lpeJIO4 Y68S7c+ZiI+shG+PeQWjwH4QZVSphrbGtlhS662E= Date: Tue, 12 Jan 2021 15:49:18 -0800 From: Andrew Morton To: akpm@linux-foundation.org, linmiaohe@huawei.com, linux-mm@kvack.org, luoshijie1@huawei.com, mm-commits@vger.kernel.org, stable@vger.kernel.org, torvalds@linux-foundation.org, urezki@gmail.com Subject: [patch 05/10] mm/vmalloc.c: fix potential memory leak Message-ID: <20210112234918.AY5LtPz7k%akpm@linux-foundation.org> In-Reply-To: <20210112154839.abeb6e57de79480059fd9b0e@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Miaohe Lin Subject: mm/vmalloc.c: fix potential memory leak In VM_MAP_PUT_PAGES case, we should put pages and free array in vfree. But we missed to set area->nr_pages in vmap(). So we would failed to put pages in __vunmap() because area->nr_pages = 0. Link: https://lkml.kernel.org/r/20210107123541.39206-1-linmiaohe@huawei.com Fixes: b944afc9d64d ("mm: add a VM_MAP_PUT_PAGES flag for vmap") Signed-off-by: Shijie Luo Signed-off-by: Miaohe Lin Reviewed-by: Uladzislau Rezki (Sony) Cc: Signed-off-by: Andrew Morton --- mm/vmalloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/mm/vmalloc.c~mm-vmallocc-fix-potential-memory-leak +++ a/mm/vmalloc.c @@ -2420,8 +2420,10 @@ void *vmap(struct page **pages, unsigned return NULL; } - if (flags & VM_MAP_PUT_PAGES) + if (flags & VM_MAP_PUT_PAGES) { area->pages = pages; + area->nr_pages = count; + } return area->addr; } EXPORT_SYMBOL(vmap); _