From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AA73C433DB for ; Tue, 12 Jan 2021 21:46:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE63723123 for ; Tue, 12 Jan 2021 21:46:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE63723123 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7E4956B00EE; Tue, 12 Jan 2021 16:46:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 767CA6B00F0; Tue, 12 Jan 2021 16:46:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 658226B00F1; Tue, 12 Jan 2021 16:46:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 484346B00EE for ; Tue, 12 Jan 2021 16:46:23 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0B5A7181AEF31 for ; Tue, 12 Jan 2021 21:46:23 +0000 (UTC) X-FDA: 77698457046.06.alarm41_54005c627518 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id EBCDA100359F3 for ; Tue, 12 Jan 2021 21:46:22 +0000 (UTC) X-HE-Tag: alarm41_54005c627518 X-Filterd-Recvd-Size: 3741 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 21:46:22 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3356023122; Tue, 12 Jan 2021 21:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610487981; bh=UQDaWvLBuUDRI2C+9laV/b1uo1RHw1RpRmTBFWgJcNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P7ORlgNjfyzMEo5za2dbespNyEU4nMoCr33iibDSeVjm3ic4JiE6MkH9aJieisDFE oOBxGZYlvG9fmYrPGZ/6s63dmMqW8eQHWJ+RTVQlfC33HQgpcnpyPPyP5jXiNfeSDn qA4c0Qy1Np5sta1iJOg71HxvP5A3VoCCyvkSHlKEVaHU7oZkMbdj8RHSzavHU20sCu Ir3aT2YN4QvGWD69jJ8elyQaoHzfkpiHI9X35xU5ujS/aEhFcfbLyugVcezBzwajjJ ksHwjrNjRXXHyuY9uRFm8UY5R4bCodT99R0rdfwzU9X6mfImssgWV6Ey7ShvVQaAOQ 3UZJcRW7T+8RA== Date: Tue, 12 Jan 2021 21:46:15 +0000 From: Will Deacon To: Hugh Dickins Cc: Linus Torvalds , Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , "Kirill A . Shutemov" , Vinayak Menon , Android Kernel Team Subject: Re: [PATCH v2 0/3] Create 'old' ptes for faultaround mappings on arm64 with hardware access flag Message-ID: <20210112214615.GB10434@willie-the-truck> References: <20210108171517.5290-1-will@kernel.org> <20210111133007.GA7642@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 11, 2021 at 01:03:29PM -0800, Hugh Dickins wrote: > On Mon, 11 Jan 2021, Will Deacon wrote: > > On Fri, Jan 08, 2021 at 11:34:08AM -0800, Linus Torvalds wrote: > > > On Fri, Jan 8, 2021 at 9:15 AM Will Deacon wrote: > > > > > > > > The big difference in this version is that I have reworked it based on > > > > Kirill's patch which he posted as a follow-up to the original. However, > > > > I can't tell where we've landed on that -- Linus seemed to like it, but > > > > Hugh was less enthusiastic. > > > > > > Yeah, I like it, but I have to admit that it had a disturbingly high > > > number of small details wrong for several versions. I hope you picked > > > up the final version of the code. > > > > I picked the version from here: > > > > https://lore.kernel.org/r/20201229132819.najtavneutnf7ajp@box > > > > and actually, I just noticed that willy spotted a typo in a comment, so > > I'll fix that locally as well as adding the above to a 'Link:' tag for > > reference. > > > > > At the same time, I do think that the "disturbingly high number of > > > issues" was primarily exactly _because_ the old code was so > > > incomprehensible, and I think the end result is much cleaner, so I > > > still like it. > > Just to report that I gave this v2 set a spin on a few (x86_64 and i386) > machines, and found nothing objectionable this time around. Thanks, Hugh. > And the things that I'm unenthusiastic about are exactly those details > that you and Kirill and Linus find unsatisfactory, but awkward to > eliminate: expect no new insights from me! Well, I'll keep you on CC for v3 -- just in case! Will