From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D568C433DB for ; Tue, 12 Jan 2021 19:16:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E34AD2310A for ; Tue, 12 Jan 2021 19:16:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E34AD2310A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3FBCA6B00AB; Tue, 12 Jan 2021 14:16:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D3646B00AC; Tue, 12 Jan 2021 14:16:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C2E56B00AD; Tue, 12 Jan 2021 14:16:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 172776B00AB for ; Tue, 12 Jan 2021 14:16:38 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D7AE18248068 for ; Tue, 12 Jan 2021 19:16:37 +0000 (UTC) X-FDA: 77698079634.19.clock43_5412aec27517 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id A50D91AD1BA for ; Tue, 12 Jan 2021 19:16:37 +0000 (UTC) X-HE-Tag: clock43_5412aec27517 X-Filterd-Recvd-Size: 4954 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 19:16:37 +0000 (UTC) Received: by mail-qk1-f178.google.com with SMTP id w79so2916970qkb.5 for ; Tue, 12 Jan 2021 11:16:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=o1zIRVvlIdRblMLiKBkvOC2xTqqgWEYJWublDCntGKI=; b=Da7TPxsZbAydOXbhtG7CUOIg2Nm2ArteVZzps33I+QYA88IXOvrAcZmBfOvgKZHrW2 5xKm4Fv17nGR2q7lW9z4dwal24qzwZvB0fa+wGXd9xUmAwIloOeTyaOiarW8n4P0VQNh XQ6nUtz2ZM+af8kIE4paLbqqDdM1UoHefYEcRJjyhw4JQ/M0h5SiddnSe7a+By8xuP2o /03u6z1c91MeNGL1yCzIA/UHTVEJBuH+GTh2XntKVLpnCWoTXMXeQE9Oc65ORn4h3otx 9F+46jMS3FGHED3ZQEuqbG9jDWrOW9imstwH46H9sxdyewZZIeWLuiENVHhglc5mKMxN fcPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o1zIRVvlIdRblMLiKBkvOC2xTqqgWEYJWublDCntGKI=; b=lN2Rcd43seccwuV2euWW5edrjygF+6jQfN+zDsVyoG3AKWUKXBhf+lcyN4thA/MIFe +6vtfZejSkEwYKLdx5XfazRzScw73h4L/EFq8QYxfTt1wkDd9ZFS+I23U9MTQ4euYh+m ihpVM0/cKnehKeNAjM3D7o6MlmDwqLbuzhk4BVTx/Rj9c58m6J4IWjvLg7uBXqTyG5ni x9uZY2CbcuYkE+OHejcjBFzoBjdI7OzbbFmBTyDXPEwrdSzq3gZCEmi8m+jzhqoUM0YX Oa9ayZEQH3bJXzi402IBc39A26dTSJ7XEuHqFj8BZ6ws+AM4ZFDJji8JCGa5DLCQKDty 3wVg== X-Gm-Message-State: AOAM5312fGXfAQ6CT4aUm5H1ayuMrJJLoE/4j2f9TguJ/YZZd0gt0wlD UKCp1cIQfgjBy672CWMFH3c= X-Google-Smtp-Source: ABdhPJwyAQWnSzB8tbSH8RaXOA8oPrFxD5dGzBKdUZCbIdUEIKw9APEZGHvyrjE5nrYO8+Sqsdh9Og== X-Received: by 2002:a05:620a:983:: with SMTP id x3mr885878qkx.231.1610478996551; Tue, 12 Jan 2021 11:16:36 -0800 (PST) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id h26sm1694864qtc.81.2021.01.12.11.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 11:16:35 -0800 (PST) Date: Tue, 12 Jan 2021 12:16:34 -0700 From: Nathan Chancellor To: Arnd Bergmann Cc: Andrew Morton , Nick Desaulniers , "Kirill A. Shutemov" , Wei Yang , Arnd Bergmann , Vlastimil Babka , Dmitry Safonov <0x7f454c46@gmail.com>, Brian Geffon , linux-mm@kvack.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] mm/mremap: fix BUILD_BUG_ON() error in get_extent Message-ID: <20210112191634.GA1587546@ubuntu-m3-large-x86> References: <20201230154104.522605-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201230154104.522605-1-arnd@kernel.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 30, 2020 at 04:40:40PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang cannt evaluate this function argument at compile time > when the function is not inlined, which leads to a link > time failure: > > ld.lld: error: undefined symbol: __compiletime_assert_414 > >>> referenced by mremap.c > >>> mremap.o:(get_extent) in archive mm/built-in.a > > Mark the function as __always_inline to avoid it. > > Fixes: 9ad9718bfa41 ("mm/mremap: calculate extent in one place") > Signed-off-by: Arnd Bergmann I would like to see some movement on getting this fixed in 5.11. As it stands, this is one of three __compiletime_assert references with CONFIG_UBSAN_UNSIGNED_OVERFLOW. If we want to keep the BUILD_BUG() around, I think this is fine. Alternatively, turning it into a runtime check would be fine too. Reviewed-by: Nathan Chancellor > --- > mm/mremap.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/mremap.c b/mm/mremap.c > index c5590afe7165..1cb464a07184 100644 > --- a/mm/mremap.c > +++ b/mm/mremap.c > @@ -336,8 +336,9 @@ enum pgt_entry { > * valid. Else returns a smaller extent bounded by the end of the source and > * destination pgt_entry. > */ > -static unsigned long get_extent(enum pgt_entry entry, unsigned long old_addr, > - unsigned long old_end, unsigned long new_addr) > +static __always_inline unsigned long get_extent(enum pgt_entry entry, > + unsigned long old_addr, unsigned long old_end, > + unsigned long new_addr) > { > unsigned long next, extent, mask, size; > > -- > 2.29.2