* Re: [PATCH v3] pgo: add clang's Profile Guided Optimization infrastructure [not found] <20210112053113.4180271-1-morbo@google.com> @ 2021-01-12 9:10 ` kernel test robot 2021-01-12 17:22 ` Nathan Chancellor 0 siblings, 1 reply; 2+ messages in thread From: kernel test robot @ 2021-01-12 9:10 UTC (permalink / raw) To: Bill Wendling, Jonathan Corbet, Masahiro Yamada, linux-doc, linux-kernel, linux-kbuild, clang-built-linux, Andrew Morton Cc: kbuild-all, Linux Memory Management List, Nathan Chancellor, Nick Desaulniers [-- Attachment #1: Type: text/plain, Size: 2575 bytes --] Hi Bill, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc3] [cannot apply to powerpc/next s390/features tip/x86/core next-20210111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Bill-Wendling/pgo-add-clang-s-Profile-Guided-Optimization-infrastructure/20210112-133315 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a0d54b4f5b219fb31f0776e9f53aa137e78ae431 config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/6ab85bae7667afd0aa68c6442b7ca5c369fa1088 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Bill-Wendling/pgo-add-clang-s-Profile-Guided-Optimization-infrastructure/20210112-133315 git checkout 6ab85bae7667afd0aa68c6442b7ca5c369fa1088 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): kernel/pgo/instrument.c:72:6: warning: no previous prototype for '__llvm_profile_instrument_target' [-Wmissing-prototypes] 72 | void __llvm_profile_instrument_target(u64 target_value, void *data, u32 index) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/pgo/instrument.c:135:6: warning: no previous prototype for '__llvm_profile_instrument_range' [-Wmissing-prototypes] 135 | void __llvm_profile_instrument_range(u64 target_value, void *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> kernel/pgo/instrument.c:179:6: warning: no previous prototype for '__llvm_profile_instrument_memop' [-Wmissing-prototypes] 179 | void __llvm_profile_instrument_memop(u64 target_value, void *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/__llvm_profile_instrument_memop +179 kernel/pgo/instrument.c 174 175 /* 176 * The target values are partitioned into multiple ranges. The range spec is 177 * defined in compiler-rt/include/profile/InstrProfData.inc. 178 */ > 179 void __llvm_profile_instrument_memop(u64 target_value, void *data, --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 77822 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3] pgo: add clang's Profile Guided Optimization infrastructure 2021-01-12 9:10 ` [PATCH v3] pgo: add clang's Profile Guided Optimization infrastructure kernel test robot @ 2021-01-12 17:22 ` Nathan Chancellor 0 siblings, 0 replies; 2+ messages in thread From: Nathan Chancellor @ 2021-01-12 17:22 UTC (permalink / raw) To: kernel test robot Cc: Bill Wendling, Jonathan Corbet, Masahiro Yamada, linux-doc, linux-kernel, linux-kbuild, clang-built-linux, Andrew Morton, kbuild-all, Linux Memory Management List, Nick Desaulniers On Tue, Jan 12, 2021 at 05:10:04PM +0800, kernel test robot wrote: > Hi Bill, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v5.11-rc3] > [cannot apply to powerpc/next s390/features tip/x86/core next-20210111] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Bill-Wendling/pgo-add-clang-s-Profile-Guided-Optimization-infrastructure/20210112-133315 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a0d54b4f5b219fb31f0776e9f53aa137e78ae431 > config: x86_64-allyesconfig (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 Hmmm... This should probably be gated on CC_IS_CLANG? Or even better CLANG_VERSION >= 120000 due to https://github.com/ClangBuiltLinux/linux/issues/1252? > reproduce (this is a W=1 build): > # https://github.com/0day-ci/linux/commit/6ab85bae7667afd0aa68c6442b7ca5c369fa1088 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Bill-Wendling/pgo-add-clang-s-Profile-Guided-Optimization-infrastructure/20210112-133315 > git checkout 6ab85bae7667afd0aa68c6442b7ca5c369fa1088 > # save the attached .config to linux build tree > make W=1 ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > > kernel/pgo/instrument.c:72:6: warning: no previous prototype for '__llvm_profile_instrument_target' [-Wmissing-prototypes] > 72 | void __llvm_profile_instrument_target(u64 target_value, void *data, u32 index) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > kernel/pgo/instrument.c:135:6: warning: no previous prototype for '__llvm_profile_instrument_range' [-Wmissing-prototypes] > 135 | void __llvm_profile_instrument_range(u64 target_value, void *data, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> kernel/pgo/instrument.c:179:6: warning: no previous prototype for '__llvm_profile_instrument_memop' [-Wmissing-prototypes] > 179 | void __llvm_profile_instrument_memop(u64 target_value, void *data, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > I still think that this warning will show up with clang at W=1. Given that these are compiler inserted functions, the prototypes don't matter but we could shut it up by just putting the prototypes right above the functions like was done in commit 1e1b6d63d634 ("lib/string.c: implement stpcpy"). Cheers, Nathan ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-12 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210112053113.4180271-1-morbo@google.com>
2021-01-12 9:10 ` [PATCH v3] pgo: add clang's Profile Guided Optimization infrastructure kernel test robot
2021-01-12 17:22 ` Nathan Chancellor
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox