From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1570C433DB for ; Tue, 12 Jan 2021 11:17:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6673A208B3 for ; Tue, 12 Jan 2021 11:17:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6673A208B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB7FA8D0097; Tue, 12 Jan 2021 06:17:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D406E8D0090; Tue, 12 Jan 2021 06:17:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C306F8D0097; Tue, 12 Jan 2021 06:17:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id A70128D0090 for ; Tue, 12 Jan 2021 06:17:09 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6FE6D824999B for ; Tue, 12 Jan 2021 11:17:09 +0000 (UTC) X-FDA: 77696871378.01.skate79_160647d27515 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 568C11004A0B5 for ; Tue, 12 Jan 2021 11:17:09 +0000 (UTC) X-HE-Tag: skate79_160647d27515 X-Filterd-Recvd-Size: 2046 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 11:17:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A69F5AD1E; Tue, 12 Jan 2021 11:17:07 +0000 (UTC) Date: Tue, 12 Jan 2021 12:17:05 +0100 From: Oscar Salvador To: David Hildenbrand Cc: akpm@linux-foundation.org, mhocko@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, pasha.tatashin@soleen.com Subject: Re: [PATCH 1/5] mm: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE Message-ID: <20210112111700.GA13374@linux> References: <20201217130758.11565-1-osalvador@suse.de> <20201217130758.11565-2-osalvador@suse.de> <21932014-3027-8ad9-2140-f63500c641d7@redhat.com> <20210112072643.GA10774@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 12, 2021 at 11:12:30AM +0100, David Hildenbrand wrote: > On 12.01.21 08:26, Oscar Salvador wrote: > > You mean introducing only mm/Kconfig change in this patch, and then > > arch/*/Kconfig changes in separate patches at the end of the series? > > Yeah, or squashing the leftovers of this patch (3 LOC) into patch #2. Ok, makes sense. > > I can certainly do that, not sure how much will help with the review, > > but it might help when bisecting. > > It's usually nicer to explicitly enable stuff per architecture, stating > why it works on that architecture (and in the best case, even was > tested!). :) Fine by me. I will prepare another re-spin with that in mind then. It would be great to have some feedback on patch#2 before that (in case you find some time ;-). Thanks! -- Oscar Salvador SUSE L3