From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D51C433E0 for ; Tue, 12 Jan 2021 07:26:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F63322CBE for ; Tue, 12 Jan 2021 07:26:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F63322CBE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 39B4F8D006A; Tue, 12 Jan 2021 02:26:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3723D8D0051; Tue, 12 Jan 2021 02:26:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AE6D8D006A; Tue, 12 Jan 2021 02:26:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 155448D0051 for ; Tue, 12 Jan 2021 02:26:52 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D9234180AD815 for ; Tue, 12 Jan 2021 07:26:51 +0000 (UTC) X-FDA: 77696291022.14.trees97_5e0939c27513 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id B7F4B18229835 for ; Tue, 12 Jan 2021 07:26:51 +0000 (UTC) X-HE-Tag: trees97_5e0939c27513 X-Filterd-Recvd-Size: 2037 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 07:26:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D95D2AC95; Tue, 12 Jan 2021 07:26:49 +0000 (UTC) Date: Tue, 12 Jan 2021 08:26:47 +0100 From: Oscar Salvador To: David Hildenbrand Cc: akpm@linux-foundation.org, mhocko@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, pasha.tatashin@soleen.com Subject: Re: [PATCH 1/5] mm: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE Message-ID: <20210112072643.GA10774@linux> References: <20201217130758.11565-1-osalvador@suse.de> <20201217130758.11565-2-osalvador@suse.de> <21932014-3027-8ad9-2140-f63500c641d7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21932014-3027-8ad9-2140-f63500c641d7@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 11, 2021 at 05:52:19PM +0100, David Hildenbrand wrote: > On 17.12.20 14:07, Oscar Salvador wrote: > > In order to use self-hosted memmap array, the platform needs to have > > support for CONFIG_SPARSEMEM_VMEMMAP and altmap. > > Currently, only arm64, PPC and x86_64 have the support, so enable those > > platforms with ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE. > > "In the first version, only .... will support it". I will try to be more specific. > > I'd probably split off enabling it per architecture in separate patches > and the end of the series. You mean introducing only mm/Kconfig change in this patch, and then arch/*/Kconfig changes in separate patches at the end of the series? I can certainly do that, not sure how much will help with the review, but it might help when bisecting. > Apart from that looks good. Thanks for taking a look David! -- Oscar Salvador SUSE L3