From: "Jörn Engel" <joern@purestorage.com>
To: Marco Elver <elver@google.com>
Cc: akpm@linux-foundation.org, glider@google.com, dvyukov@google.com,
andreyknvl@google.com, jannh@google.com, mark.rutland@arm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kasan-dev@googlegroups.com
Subject: Re: [PATCH mm 1/2] kfence: add option to use KFENCE without static keys
Date: Mon, 11 Jan 2021 11:53:23 -0800 [thread overview]
Message-ID: <20210111195323.GA842777@cork> (raw)
In-Reply-To: <20210111091544.3287013-1-elver@google.com>
On Mon, Jan 11, 2021 at 10:15:43AM +0100, Marco Elver wrote:
> For certain usecases, specifically where the sample interval is always
> set to a very low value such as 1ms, it can make sense to use a dynamic
> branch instead of static branches due to the overhead of toggling a
> static branch.
I ended up with 100µs and couldn't measure a performance problem in our
benchmarks. My results don't have predictive value for anyone else, of
course.
> Therefore, add a new Kconfig option to remove the static branches and
> instead check kfence_allocation_gate if a KFENCE allocation should be
> set up.
>
> Suggested-by: Jörn Engel <joern@purestorage.com>
> Signed-off-by: Marco Elver <elver@google.com>
Reviewed-by: Jörn Engel <joern@purestorage.com>
Jörn
--
One of the things I’ve discovered over the years, is that you can
create change or you can receive credit – not both.
-- Stephen Downes
prev parent reply other threads:[~2021-01-11 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 9:15 Marco Elver
2021-01-11 9:15 ` [PATCH mm 2/2] kfence: show access type in report Marco Elver
2021-01-11 21:15 ` Jörn Engel
2021-01-11 19:53 ` Jörn Engel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111195323.GA842777@cork \
--to=joern@purestorage.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=jannh@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox