From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5682DC433DB for ; Mon, 11 Jan 2021 15:52:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A68D822A83 for ; Mon, 11 Jan 2021 15:52:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A68D822A83 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 05EAD6B015C; Mon, 11 Jan 2021 10:52:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 00FCB6B0178; Mon, 11 Jan 2021 10:52:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF2426B0180; Mon, 11 Jan 2021 10:52:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id C5DC66B015C for ; Mon, 11 Jan 2021 10:52:48 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 71DE9180AD817 for ; Mon, 11 Jan 2021 15:52:48 +0000 (UTC) X-FDA: 77693937216.16.metal88_2b0151c2750e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 49724100E690C for ; Mon, 11 Jan 2021 15:52:48 +0000 (UTC) X-HE-Tag: metal88_2b0151c2750e X-Filterd-Recvd-Size: 5151 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 15:52:47 +0000 (UTC) Received: by mail-qv1-f46.google.com with SMTP id az16so7597681qvb.5 for ; Mon, 11 Jan 2021 07:52:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DTtX5CQ79mvCElDxODO77cVTuyuq22GdoAJZjW803s4=; b=PP5P9Js+hVVOM2eTY6pAKi4aMnJ/nRqExT3Coc1R4TFDgp6o81GIvIAF45yGnE5EdU n/S/92pNpsBAj2aX5b/s4lAozrka3jVUmUIGgnoqI+ZX9dCIfwYhxNHy4b5vtKSKsAE0 mgMRxsb5f2T4K+xe2zmXwStNx17ucbYwtLOZxxPNl00kCpj5n15TLGNq0J8QrCyIuOaK btbXvNMhsVa1pl6NvWQwlaq4KuScx/2dlraYITujsK5duvl9f8itQxUw8TDMmwMGOeBE xEU0jAEkUHuScctGS4ZMweae+n8CLHQ+VgnGf4j3jJWZEe5QbyyhAva/ECM9vKEUyfns e3UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DTtX5CQ79mvCElDxODO77cVTuyuq22GdoAJZjW803s4=; b=EcVi/z2dWkFHPk82xQo2tlroirN4Pt6hoSsgH6JdU1aLxfHO4B/vk8gfXCEdZr3A4r xnx8PHkuraH1ST/61tHUAIXTSHly4NCd89YhgqEpdKEdzvfdfXzRs7DcKsRkV4Gsxj9z UteKI49I4C0IjokVd7Oo+3PdOU3WVSV+mk0pS+IXFbBP7p4gJWoqeGZV1/4x8xzpVpQO bMQcUs36idfgYvs5e4wx1scBKwIYavNOcG2WQ732ENGa3nDyUi0HtRs1yFZyrt7UUZHK fIhMJd5IM4UEqtncXsN+ftiFseylGHthFtcKHRcALtIZHCt/YAlPGPCTfCEUxMDwb1oM lCjQ== X-Gm-Message-State: AOAM532BIfugIkebwT9/WTXLUfxDE9SJihhhqP8ydVIySkVm3/hXogMx y5HeppML7wfYsBphnRYQpmZwqQ== X-Google-Smtp-Source: ABdhPJyKYjAT3LmoVbBTtIHwrAxf+Io6skqOJi1oDcms79ORoN0cLhj8cmluyb8xaWTDdeJLBNsZAw== X-Received: by 2002:a05:6214:14af:: with SMTP id bo15mr249528qvb.19.1610380367039; Mon, 11 Jan 2021 07:52:47 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id r6sm67695qkk.127.2021.01.11.07.52.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 07:52:46 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kyzUr-005YBj-Kq; Mon, 11 Jan 2021 11:52:45 -0400 Date: Mon, 11 Jan 2021 11:52:45 -0400 From: Jason Gunthorpe To: Andrea Arcangeli Cc: Linus Torvalds , Andrew Morton , Linux-MM , Linux Kernel Mailing List , Yu Zhao , Andy Lutomirski , Peter Xu , Pavel Emelyanov , Mike Kravetz , Mike Rapoport , Minchan Kim , Will Deacon , Peter Zijlstra , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Oleg Nesterov , Jann Horn , Kees Cook , John Hubbard , Leon Romanovsky , Jan Kara , Kirill Tkhai , Nadav Amit , Jens Axboe Subject: Re: [PATCH 0/1] mm: restore full accuracy in COW page reuse Message-ID: <20210111155245.GM504133@ziepe.ca> References: <20210110004435.26382-1-aarcange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 09, 2021 at 09:51:14PM -0500, Andrea Arcangeli wrote: > Are we spending 32bit in mm_struct atomic_t just to call atomic_set(1) > on it? Why isn't it a MMF_HAS_PINNED that already can be set > atomically under mmap_read_lock too? There's bit left free there, we > didn't run out yet to justify wasting another 31 bits. I hope I'm > overlooking something. It needs to be atomic because it is set under gup fast, no mmap lock. Peter and myself did not find another place to put this that was already atomic > The existence of FOLL_LONGTERM is good and makes a difference at times > for writeback if it's on a MAP_SHARED, or it makes difference during > GUP to do a page_migrate before taking the pin, but for the whole rest > of the VM it's irrelevant if it's long or short term, so I'm also > concerned from what Jason mentioned about long term pins being treated > differently within the VM. Why? They are different. write protect doesn't stop modification of the data. How is that not a relavent and real difference? Jason