From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A45C433E0 for ; Mon, 11 Jan 2021 14:27:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 57DAF224D2 for ; Mon, 11 Jan 2021 14:27:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57DAF224D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD0BC8D0033; Mon, 11 Jan 2021 09:27:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5A528D0020; Mon, 11 Jan 2021 09:27:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFA668D0033; Mon, 11 Jan 2021 09:27:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 9AA5B8D0020 for ; Mon, 11 Jan 2021 09:27:26 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 536A3181AEF15 for ; Mon, 11 Jan 2021 14:27:26 +0000 (UTC) X-FDA: 77693722092.30.blood09_4608c9d2750d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 10A23180B3AA7 for ; Mon, 11 Jan 2021 14:27:26 +0000 (UTC) X-HE-Tag: blood09_4608c9d2750d X-Filterd-Recvd-Size: 3299 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 14:27:25 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 737C122473; Mon, 11 Jan 2021 14:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610375244; bh=NeQZAI3Se6XnjBLgTKT5kwYcHmcn0zV0JGG0txZc5HA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JER9akiF6aHhzPy1WYWZfp7WhPw4SxmNlvZhH5vN2GhTQ7jRed4db3ImU5rXEjSAi mrtqazmvZoUKQYJ9rFF16yAtoJmcdcjKv94VpMeTNUBixIL/eKT9Q2eYQfNGyCLdWa ThQIRnU9rwrPz5kP9b9pMaJQbvY6mLvtMr7e9jw2w3oqNZ5G//M+zuGWwJ66JMBZds AlIYa//Thf6u+BxkDvys78gi06c3TfomSX5ht7+7Bxzulx9+ZcNGgVGXPb+XP/b7Mk pbB5QdbwqOkAiACEYea5ccWGwDTAu79n8qKVvSdGAWb7rC4ZTAm+3HZSr1gvm7iTpH 47AQpo6KJEprA== Date: Mon, 11 Jan 2021 14:27:19 +0000 From: Will Deacon To: "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , "Kirill A . Shutemov" , Linus Torvalds , Vinayak Menon , Hugh Dickins , kernel-team@android.com Subject: Re: [PATCH v2 1/3] mm: Cleanup faultaround and finish_fault() codepaths Message-ID: <20210111142718.GC7642@willie-the-truck> References: <20210108171517.5290-1-will@kernel.org> <20210108171517.5290-2-will@kernel.org> <20210111142620.ylv3ccrsubef62mi@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210111142620.ylv3ccrsubef62mi@box> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 11, 2021 at 05:26:20PM +0300, Kirill A. Shutemov wrote: > On Fri, Jan 08, 2021 at 05:15:15PM +0000, Will Deacon wrote: > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index ecdf8a8cd6ae..801dd99f733c 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -542,8 +542,8 @@ struct vm_fault { > > * is not NULL, otherwise pmd. > > */ > > pgtable_t prealloc_pte; /* Pre-allocated pte page table. > > - * vm_ops->map_pages() calls > > - * alloc_set_pte() from atomic context. > > + * vm_ops->map_pages() sets up a page > > + * table from from atomic context. > > * do_fault_around() pre-allocates > > * page table to avoid allocation from > > * atomic context. > > The typo Matthew has pointed out: > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index d3d4e307fa09..358fc8616d8b 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -535,7 +535,7 @@ struct vm_fault { > */ > pgtable_t prealloc_pte; /* Pre-allocated pte page table. > * vm_ops->map_pages() sets up a page > - * table from from atomic context. > + * table from atomic context. > * do_fault_around() pre-allocates > * page table to avoid allocation from > * atomic context. Cheers, fixed locally and will include for v3! Will