From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 496B4C433DB for ; Mon, 11 Jan 2021 14:11:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C75152242A for ; Mon, 11 Jan 2021 14:11:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C75152242A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1DD048D002E; Mon, 11 Jan 2021 09:11:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18DF08D0020; Mon, 11 Jan 2021 09:11:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07C988D002E; Mon, 11 Jan 2021 09:11:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id D900C8D0020 for ; Mon, 11 Jan 2021 09:11:46 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 95AA8181AEF10 for ; Mon, 11 Jan 2021 14:11:46 +0000 (UTC) X-FDA: 77693682612.15.doll46_5709a672750d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 65CE31814B0C8 for ; Mon, 11 Jan 2021 14:11:46 +0000 (UTC) X-HE-Tag: doll46_5709a672750d X-Filterd-Recvd-Size: 5314 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 14:11:45 +0000 (UTC) Received: by mail-lj1-f180.google.com with SMTP id w26so3550878ljo.4 for ; Mon, 11 Jan 2021 06:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZReoOwflH9bo7F+gPMdBMhNPvju0+jhg+phHdqxtW9U=; b=bbuae7i0ajVSZs/iE1GxJS5JTwYsINPj50ZdGUxE8FoqN7c/ITb936oHhlK0+HrIG4 eUpaYUbVGgplw/D+vDub5l/FTKPXs9IvB+44IXU/4bS7bhCHcI3u3gXrt0ur2/2hOU/e oe4rj+MEcQDpceTKAaaqkgBd0oNsV2JkHKZFXU98u1kRdxXDtKPcqYSA7eerbF/5IuM0 9S5xCvWno6qF4y/4oLvDqOGG1E+m6xW1z5Zea2iFihtRoI55+j2qOoGclCbeg7VD+Ws5 1qy4ESog4Jg16KYQQee2aEwiNqAm47G/orZksLVspkrI9h7t3ssHlKUY3J/VM9dfsQwb q/jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZReoOwflH9bo7F+gPMdBMhNPvju0+jhg+phHdqxtW9U=; b=T3w36GTwpod3791pAQyuyz1O38g2uYEo7e+Qq+ORk6OYc57SpvtkN1cb7pNBWZ4OJL TgLnAXoY63x58pDQ0MbuMmD28SoLYP/uvzNgJDrsNEVJFso/1myzeJnWS7qhDgS3k25b WRItiW35j4W2zUB/u6z3as4CicwywjPCr+rcDkv+a4FFCFr9DsT3h2QH8uQaEMmEkJSx 16R+r03LYZ/OswlgnkADJqBIjUGSHp8EUKF2XdCy9pPcwfOid1PCGDCDdinx7JQx2lt+ wETXAIcuPeCHz4n+6lMG0QNLXai3TEYYqJ6f/I2fu+43zb2MvZA/hmHaJV3fEbI8xKsd MhKg== X-Gm-Message-State: AOAM532oSRYLk0JoPypNXbxSMhn5TLtBzj6RhNM98DsQVhJdLp0vV7/V koI5EGV8lvX5nIh/YqRUwDVwmQ== X-Google-Smtp-Source: ABdhPJwz/2c/lBqYKtQvgp5ukYJ1MrpG+yfHbeuPoqGm/F7I13cJ0at60TMTPhYSKPvLK/IGSK8Pbw== X-Received: by 2002:a05:651c:c1:: with SMTP id 1mr7897396ljr.124.1610374304175; Mon, 11 Jan 2021 06:11:44 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id t28sm3512091ljo.45.2021.01.11.06.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 06:11:43 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id E898F102238; Mon, 11 Jan 2021 17:11:47 +0300 (+03) Date: Mon, 11 Jan 2021 17:11:47 +0300 From: "Kirill A. Shutemov" To: Andrea Arcangeli Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yu Zhao , Andy Lutomirski , Peter Xu , Pavel Emelyanov , Mike Kravetz , Mike Rapoport , Minchan Kim , Will Deacon , Peter Zijlstra , Linus Torvalds , Hugh Dickins , Matthew Wilcox , Oleg Nesterov , Jann Horn , Kees Cook , John Hubbard , Leon Romanovsky , Jason Gunthorpe , Jan Kara , Kirill Tkhai , Nadav Amit , Jens Axboe Subject: Re: [PATCH 1/1] mm: restore full accuracy in COW page reuse Message-ID: <20210111141147.wzk5rvycsiitnnrt@box> References: <20210110004435.26382-1-aarcange@redhat.com> <20210110004435.26382-2-aarcange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 09, 2021 at 09:54:05PM -0500, Andrea Arcangeli wrote: > Hello, > > On Sat, Jan 09, 2021 at 07:44:35PM -0500, Andrea Arcangeli wrote: > > allowing a child to corrupt memory in the parent. That's a problem > > that could happen not-maliciously too. So the scenario described > > I updated the above partly quoted sentence since in the previous > version it didn't have full accuracy: > > https://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git/commit/?id=fc5a76b1c14e5e6cdc64ece306fc03773662d98a > > "However since a single transient GUP pin on a tail page, would elevate > the page_count for all other tail pages (unlike the mapcount which is > subpage granular), the COW page reuse inaccuracy would then cross > different vmas and the effect would happen at a distance in vma of > different processes. A single GUP pin taken on a subpage mapped in a > different process could trigger 511 false positive COWs copies in the > local process, after a fork()." > > This a best effort to try to document all side effects, but it'd be > great to hear from Kirill too on the above detail to have > confirmation. Yes, this side effect is possible. But I wouldn't worry about too much. If it routinely happens in a real workloads (I doubt it does), the workload can tune it with MADV_NOHUGEPAGE/MADV_DONTFORK/MADV_WIPEONFORK or something. -- Kirill A. Shutemov