From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C763FC433E0 for ; Mon, 11 Jan 2021 13:43:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 52247221FD for ; Mon, 11 Jan 2021 13:43:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52247221FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A229E6B01B1; Mon, 11 Jan 2021 08:43:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D25F8D0020; Mon, 11 Jan 2021 08:43:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90F456B01F0; Mon, 11 Jan 2021 08:43:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 7B8E46B01B1 for ; Mon, 11 Jan 2021 08:43:13 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 351BF1DF5 for ; Mon, 11 Jan 2021 13:43:13 +0000 (UTC) X-FDA: 77693610666.17.hall22_480ba922750d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 19CEC180D0194 for ; Mon, 11 Jan 2021 13:43:13 +0000 (UTC) X-HE-Tag: hall22_480ba922750d X-Filterd-Recvd-Size: 1760 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 13:43:12 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2F36DAB7A; Mon, 11 Jan 2021 13:43:11 +0000 (UTC) Date: Mon, 11 Jan 2021 14:43:08 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org, hca@linux.ibm.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Vasily Gorbik , Will Deacon , Ard Biesheuvel , Mark Rutland Subject: Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform Message-ID: <20210111134303.GA3031@linux> References: <1608218912-28932-1-git-send-email-anshuman.khandual@arm.com> <1608218912-28932-2-git-send-email-anshuman.khandual@arm.com> <10e733fa-4568-d38f-9b95-2ccc5dc627b8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10e733fa-4568-d38f-9b95-2ccc5dc627b8@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 11, 2021 at 11:51:47AM +0100, David Hildenbrand wrote: > AFAIKs, all memhp_get_pluggable_range() users pass "1". > > What about the "add_pages()-only" path? I guess you refer to memremap_pages(), right? If so, moving the added memhp_range_allowed() check above the if-else might do the trick -- Oscar Salvador SUSE L3